From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
rostedt@goodmis.org, tglx@linutronix.de,
paulmck@linux.vnet.ibm.com, linux-rt-users@vger.kernel.org,
kernel@pengutronix.de
Subject: Re: [PATCH rt] fix "list_bl.h: make list head locking RT safe" for !SMP && !DEBUG_SPINLOCK
Date: Tue, 09 Jul 2013 09:39:14 +0200 [thread overview]
Message-ID: <51DBBE22.8060403@linutronix.de> (raw)
In-Reply-To: <51DB40BA.60607@windriver.com>
On 07/09/2013 12:44 AM, Paul Gortmaker wrote:
> On 13-07-08 06:26 PM, Uwe Kleine-König wrote:
>> and so depending on LIST_BL_LOCKMASK being one. But LIST_BL_LOCKMASK is
>> only one if at least on of CONFIG_SMP and CONFIG_DEBUG_SPINLOCK are
>> defined. Without these the value returned by hlist_bl_first has the
>> zeroth bit set which likely results in a crash.
>
> The incorrect assumption that I made was that the bit spin locks
> still set/cleared the bit in the !SMP case. So if we set the bit
> and the mask is zero, we get the mismatch, giving something like:
>
> Acked-by: Paul Gortmaker <paul.gortmaker@windriver.com>
> Tested-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Thanks everyone.
>
> Thanks,
> Paul.
Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2013-07-09 7:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-08 22:26 [PATCH rt] fix "list_bl.h: make list head locking RT safe" for !SMP && !DEBUG_SPINLOCK Uwe Kleine-König
2013-07-08 22:44 ` Paul Gortmaker
2013-07-09 7:39 ` Sebastian Andrzej Siewior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51DBBE22.8060403@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=kernel@pengutronix.de \
--cc=linux-rt-users@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).