Re: [ANNOUNCE] 3.10.6-rt3

[Sebastian Andrzej Siewior <bigeasy@linutronix.de>]

On 08/15/2013 09:22 PM, Steven Rostedt wrote:
> On Thu, 15 Aug 2013 11:42:55 -0700
> Fernando Lopez-Lezcano <nando@ccrma.Stanford.EDU> wrote:
> 
>> On 08/12/2013 09:34 AM, Sebastian Andrzej Siewior wrote:
>>> Dear RT folks!
>>>
>>> I'm pleased to announce the v3.10.6-rt3 patch set.
>>
>> I'm getting this when trying to build:
>>
>> drivers/md/bcache/request.c: In function 'cached_dev_write_complete':
>> drivers/md/bcache/request.c:1008:2: error: implicit declaration of 
>> function 'up_read_non_owner' [-Werror=implicit-function-declaration]
>>    up_read_non_owner(&dc->writeback_lock);
>>    ^
>> drivers/md/bcache/request.c: In function 'request_write':
>> drivers/md/bcache/request.c:1034:2: error: implicit declaration of 
>> function 'down_read_non_owner' [-Werror=implicit-function-declaration]
>>    down_read_non_owner(&dc->writeback_lock);
>>    ^
>> cc1: some warnings being treated as errors
>>
> 
> Can you send us your config.

The problem is that bcache is using new semaphore functions which it
just introduced which rt does not know about. The comment above their
definition says that it is wrong to use them and completion is the
right way to do it.
So my question is, why don't we use completion but this nasty hack?

> 
> Thanks,
> 
> -- Steve

Sebastian