linux-rt-users.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "John Kacur" <jkacur@gmail.com>
To: rt-users <linux-rt-users@vger.kernel.org>,
	"Steven Rostedt" <rostedt@goodmis.org>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH] rt Kconfig.preempt fixes
Date: Fri, 1 Aug 2008 15:39:51 +0200	[thread overview]
Message-ID: <520f0cf10808010639y4c1a19a7kff429827d26dc8e9@mail.gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 587 bytes --]

This is a non-critical patch, that makes configuring an rt kernel a
little nicer.
Comments are welcome of course.

Signed-off-by: John Kacur <jkacur at gmail dot com>

This patch makes the following changes.
1. Hides the visibility of PREEMPT_SOFTIRQS and PREEMPT_HARDIRQS if PREEMPT_RT
(Complete Preemption) is choosen, since these values are then set (selected) to
be "y".

2. Changes the PREEMPT_HARDIRQS to depend on PREEMPT_SOFTIRQS instead of
forcing PREEMPT_SOFTIRQS to y if PREEMPT_HARDIRQS is choosen. (this is somewhat
an abuse of select)

3. Minor spelling fix. (tat to that)

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: threaded-irqs-kconfig-fix.patch --]
[-- Type: text/x-patch; name=threaded-irqs-kconfig-fix.patch, Size: 2029 bytes --]

Signed-off-by: John Kacur <jkacur at gmail dot com>

This patch makes the following changes.
1. Hides the visibility of PREEMPT_SOFTIRQS and PREEMPT_HARDIRQS if PREEMPT_RT
(Complete Preemption) is choosen, since these values are then set (selected) to
be "y".

2. Changes the PREEMPT_HARDIRQS to depend on PREEMPT_SOFTIRQS instead of
forcing PREEMPT_SOFTIRQS to y if PREEMPT_HARDIRQS is choosen. (this is somewhat
an abuse of select)

3. Minor spelling fix. (tat to that)

Index: linux-2.6.26-rt1/kernel/Kconfig.preempt
===================================================================
--- linux-2.6.26-rt1.orig/kernel/Kconfig.preempt
+++ linux-2.6.26-rt1/kernel/Kconfig.preempt
@@ -88,8 +88,10 @@ config PREEMPT
 
 config PREEMPT_SOFTIRQS
 	bool "Thread Softirqs"
+# The following line makes PREEMPT_SOFTIRQS invisible if PREEMPT_RT is y
+# However, PREEMPT_RT still sets (selects) the value of PREEMPT_SOFTIRQS to y
+	depends on PREEMPT_RT != y
 	default n
-#	depends on PREEMPT
 	help
 	  This option reduces the latency of the kernel by 'threading'
           soft interrupts. This means that all softirqs will execute
@@ -104,9 +106,12 @@ config PREEMPT_SOFTIRQS
 
 config PREEMPT_HARDIRQS
 	bool "Thread Hardirqs"
+# The following line makes PREEMPT_HARDIRQS invisible if PREEMPT_RT is y
+# However, PREEMPT_RT still sets (selects) the value of PREEMPT_HARDIRQS to y
+	depends on PREEMPT_RT != y
 	default n
 	depends on !GENERIC_HARDIRQS_NO__DO_IRQ
-	select PREEMPT_SOFTIRQS
+	depends on PREEMPT_SOFTIRQS
 	help
 	  This option reduces the latency of the kernel by 'threading'
           hardirqs. This means that all (or selected) hardirqs will run
@@ -141,7 +146,7 @@ config PREEMPT_RCU_BOOST
 	default y if PREEMPT_RT
 	help
 	  This option permits priority boosting of RCU read-side critical
-	  sections tat have been preempted and a RT process is waiting
+	  sections that have been preempted and a RT process is waiting
 	  on a synchronize_rcu.
 
 	  An RCU thread is also created that periodically wakes up and

             reply	other threads:[~2008-08-01 13:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-01 13:39 John Kacur [this message]
2008-08-20 16:10 ` [PATCH] rt Kconfig.preempt fixes Steven Rostedt
2008-08-20 17:14   ` John Kacur

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=520f0cf10808010639y4c1a19a7kff429827d26dc8e9@mail.gmail.com \
    --to=jkacur@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rt-users@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).