Re: More RT Test Programs

[John Kacur <jkacur@gmail.com>]

(Carsten - resend to cc all)

On Mon, Dec 21, 2009 at 12:49 AM, Carsten Emde <Carsten.Emde@osadl.org> wrote:
> John,
>
>> [..] I'll be posting some more tomorrow.
> Okay, great.
>
> I have found an issue with all source files of the new tests. At some
> stage between the original files and Clark's tree, the line delimiters
> changed from NL to CR/NL. Would be great, if you could move this back to NL.

Weird - I'll remove them.
It's not coming from you is it? The patch that you attached here has
^M at the end
of each line. I can run that through a script to remove it - but you
should look into
where that is coming from on your end.

>
> A second issue is related to the removal of the getcpu() definition.
> There is a leftover in svsematest.c which should also be removed for
> consistency. However, this and the other tests no longer compile in EL5
> without this definition - should we better revert this and provide a
> working recognition through "grep sched_getcpu
> /usr/include/bits/sched.h"? Or is EL5 irrelevant in this context? I
> still have an EL5 test machine where all RT kernels are tested.


Yup - I've been struggling with a resolution for this issue, I have something
to post tomorrow after my testing is complete. EL5 is not irrelevant to us.
Do you test 32-bit as well as 64-bit?


>
> Another issue is in the file backfire.c After you removed the line
>>> -    sed s/__VERSION_STRING__/$(VERSION_STRING)/ [..]
> from the Makefile, the driver is producing the rather ugly syslog message:
>  backfire driver v__VERSION_STRING__
> instead of
>  backfire driver v0.57
> or similar.
>
> We better completely remove the version display.

Thanks for the patch, I will apply it.

>
> Signed-off-by: Carsten Emde <C.Emde@osadl.org>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html