* [PATCH] rename pip to pip_stress as pip is too general
@ 2010-02-25 20:24 Uwe Kleine-König
2010-03-01 16:51 ` Uwe Kleine-König
0 siblings, 1 reply; 3+ messages in thread
From: Uwe Kleine-König @ 2010-02-25 20:24 UTC (permalink / raw)
To: linux-rt-users; +Cc: John Kacur, Clark Williams
The command name is already taken by a perl script working with CPAN
and a Python package installer.
Addresses: http://bugs.debian.org/551926
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
.gitignore | 2 +-
Makefile | 4 ++--
src/include/{pip.h => pip_stress.h} | 7 +++----
src/pi_tests/{pip.c => pip_stress.c} | 4 ++--
4 files changed, 8 insertions(+), 9 deletions(-)
rename src/include/{pip.h => pip_stress.h} (93%)
rename src/pi_tests/{pip.c => pip_stress.c} (99%)
diff --git a/.gitignore b/.gitignore
index a06031c..0d77a66 100644
--- a/.gitignore
+++ b/.gitignore
@@ -23,4 +23,4 @@ ptsematest
sendme
sigwaittest
svsematest
-pip
+pip_stress
diff --git a/Makefile b/Makefile
index 5bb8774..52f8d64 100644
--- a/Makefile
+++ b/Makefile
@@ -1,7 +1,7 @@
VERSION_STRING = 0.66
sources = cyclictest.c signaltest.c pi_stress.c rt-migrate-test.c \
- ptsematest.c sigwaittest.c svsematest.c sendme.c pip.c
+ ptsematest.c sigwaittest.c svsematest.c sendme.c pip_stress.c
TARGETS = $(sources:.c=)
@@ -79,7 +79,7 @@ svsematest: svsematest.o rt-utils.o rt-get_cpu.o
sendme: sendme.o rt-utils.o rt-get_cpu.o
$(CC) $(CFLAGS) -o $@ $^ $(LIBS) $(EXTRA_LIBS)
-pip: pip.o error.o rt-utils.o
+pip_stress: pip_stress.o error.o rt-utils.o
$(CC) $(CFLAGS) -o $@ $^ $(LIBS)
CLEANUP = $(TARGETS) *.o .depend *.*~ *.orig *.rej rt-tests.spec *.d
diff --git a/src/include/pip.h b/src/include/pip_stress.h
similarity index 93%
rename from src/include/pip.h
rename to src/include/pip_stress.h
index b2068be..8ed2452 100644
--- a/src/include/pip.h
+++ b/src/include/pip_stress.h
@@ -1,5 +1,5 @@
-#ifndef __PIP_H
-#define __PIP_H
+#ifndef __PIP_STRESS_H
+#define __PIP_STRESS_H
#include <stdio.h>
#include <stdlib.h>
@@ -37,5 +37,4 @@ int get_rt_prio(pid_t pid);
#define PROTRW PROT_READ|PROT_WRITE
#define MMAP_FLAGS MAP_SHARED|MAP_ANONYMOUS
-#endif /* __PIP_H */
-
+#endif /* __PIP_STRESS_H */
diff --git a/src/pi_tests/pip.c b/src/pi_tests/pip_stress.c
similarity index 99%
rename from src/pi_tests/pip.c
rename to src/pi_tests/pip_stress.c
index 085908b..f3568f4 100644
--- a/src/pi_tests/pip.c
+++ b/src/pi_tests/pip_stress.c
@@ -1,5 +1,5 @@
/*
- Pip - Priority Inheritance with processes
+ Pip stress - Priority Inheritance with processes
Copyright (C) 2009, John Kacur <jkacur@redhat.com>
@@ -54,7 +54,7 @@
* scheduling priorities.
*/
-#include "pip.h"
+#include "pip_stress.h"
pthread_mutex_t *resource;
--
1.7.0
--
To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] rename pip to pip_stress as pip is too general
2010-02-25 20:24 [PATCH] rename pip to pip_stress as pip is too general Uwe Kleine-König
@ 2010-03-01 16:51 ` Uwe Kleine-König
2010-03-01 19:40 ` John Kacur
0 siblings, 1 reply; 3+ messages in thread
From: Uwe Kleine-König @ 2010-03-01 16:51 UTC (permalink / raw)
To: linux-rt-users; +Cc: John Kacur, Clark Williams
The command name is already taken by a perl script working with CPAN
and a Python package installer.
While at it remove trailing whitespace from three lines in
src/pi_tests/pip_stress.c.
Closes: http://bugs.debian.org/572104
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
Hiho,
changes since last submission are:
- remove trailing whitespaces
- different bug number
Best regards
Uwe
.gitignore | 2 +-
Makefile | 4 ++--
src/include/{pip.h => pip_stress.h} | 7 +++----
src/pi_tests/{pip.c => pip_stress.c} | 10 +++++-----
4 files changed, 11 insertions(+), 12 deletions(-)
rename src/include/{pip.h => pip_stress.h} (93%)
rename src/pi_tests/{pip.c => pip_stress.c} (98%)
diff --git a/.gitignore b/.gitignore
index a06031c..0d77a66 100644
--- a/.gitignore
+++ b/.gitignore
@@ -23,4 +23,4 @@ ptsematest
sendme
sigwaittest
svsematest
-pip
+pip_stress
diff --git a/Makefile b/Makefile
index 5bb8774..52f8d64 100644
--- a/Makefile
+++ b/Makefile
@@ -1,7 +1,7 @@
VERSION_STRING = 0.66
sources = cyclictest.c signaltest.c pi_stress.c rt-migrate-test.c \
- ptsematest.c sigwaittest.c svsematest.c sendme.c pip.c
+ ptsematest.c sigwaittest.c svsematest.c sendme.c pip_stress.c
TARGETS = $(sources:.c=)
@@ -79,7 +79,7 @@ svsematest: svsematest.o rt-utils.o rt-get_cpu.o
sendme: sendme.o rt-utils.o rt-get_cpu.o
$(CC) $(CFLAGS) -o $@ $^ $(LIBS) $(EXTRA_LIBS)
-pip: pip.o error.o rt-utils.o
+pip_stress: pip_stress.o error.o rt-utils.o
$(CC) $(CFLAGS) -o $@ $^ $(LIBS)
CLEANUP = $(TARGETS) *.o .depend *.*~ *.orig *.rej rt-tests.spec *.d
diff --git a/src/include/pip.h b/src/include/pip_stress.h
similarity index 93%
rename from src/include/pip.h
rename to src/include/pip_stress.h
index b2068be..8ed2452 100644
--- a/src/include/pip.h
+++ b/src/include/pip_stress.h
@@ -1,5 +1,5 @@
-#ifndef __PIP_H
-#define __PIP_H
+#ifndef __PIP_STRESS_H
+#define __PIP_STRESS_H
#include <stdio.h>
#include <stdlib.h>
@@ -37,5 +37,4 @@ int get_rt_prio(pid_t pid);
#define PROTRW PROT_READ|PROT_WRITE
#define MMAP_FLAGS MAP_SHARED|MAP_ANONYMOUS
-#endif /* __PIP_H */
-
+#endif /* __PIP_STRESS_H */
diff --git a/src/pi_tests/pip.c b/src/pi_tests/pip_stress.c
similarity index 98%
rename from src/pi_tests/pip.c
rename to src/pi_tests/pip_stress.c
index 085908b..2b42b8f 100644
--- a/src/pi_tests/pip.c
+++ b/src/pi_tests/pip_stress.c
@@ -1,6 +1,6 @@
/*
- Pip - Priority Inheritance with processes
-
+ Pip stress - Priority Inheritance with processes
+
Copyright (C) 2009, John Kacur <jkacur@redhat.com>
This program is free software: you can redistribute it and/or modify
@@ -54,7 +54,7 @@
* scheduling priorities.
*/
-#include "pip.h"
+#include "pip_stress.h"
pthread_mutex_t *resource;
@@ -107,7 +107,7 @@ int main(void)
set_rt_prio(0, prio_min, policy);
/* We restrict this program to the first cpu, inorder to increase
- * the likelihood of a priority inversion */
+ * the likelihood of a priority inversion */
CPU_ZERO(setp);
CPU_SET(0, setp);
res = sched_setaffinity(0, sizeof(set), setp);
@@ -311,7 +311,7 @@ void init_shared_pthread_mutex(pthread_mutex_t *mutex, int protocol, int policy)
Pthread_mutexattr_init(&attr);
Pthread_mutexattr_setpshared(&attr, PTHREAD_PROCESS_SHARED);
Pthread_mutexattr_setprotocol(&attr, protocol);
-
+
Pthread_mutex_init(mutex, &attr);
}
--
1.7.0
--
To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] rename pip to pip_stress as pip is too general
2010-03-01 16:51 ` Uwe Kleine-König
@ 2010-03-01 19:40 ` John Kacur
0 siblings, 0 replies; 3+ messages in thread
From: John Kacur @ 2010-03-01 19:40 UTC (permalink / raw)
To: Uwe Kleine-König; +Cc: linux-rt-users, Clark Williams
2010/3/1 Uwe Kleine-König <u.kleine-koenig@pengutronix.de>:
> The command name is already taken by a perl script working with CPAN
> and a Python package installer.
>
> While at it remove trailing whitespace from three lines in
> src/pi_tests/pip_stress.c.
>
> Closes: http://bugs.debian.org/572104
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> Hiho,
>
> changes since last submission are:
>
> - remove trailing whitespaces
> - different bug number
>
> Best regards
> Uwe
> .gitignore | 2 +-
> Makefile | 4 ++--
> src/include/{pip.h => pip_stress.h} | 7 +++----
> src/pi_tests/{pip.c => pip_stress.c} | 10 +++++-----
> 4 files changed, 11 insertions(+), 12 deletions(-)
> rename src/include/{pip.h => pip_stress.h} (93%)
> rename src/pi_tests/{pip.c => pip_stress.c} (98%)
>
> diff --git a/.gitignore b/.gitignore
> index a06031c..0d77a66 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -23,4 +23,4 @@ ptsematest
> sendme
> sigwaittest
> svsematest
> -pip
> +pip_stress
> diff --git a/Makefile b/Makefile
> index 5bb8774..52f8d64 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1,7 +1,7 @@
> VERSION_STRING = 0.66
>
> sources = cyclictest.c signaltest.c pi_stress.c rt-migrate-test.c \
> - ptsematest.c sigwaittest.c svsematest.c sendme.c pip.c
> + ptsematest.c sigwaittest.c svsematest.c sendme.c pip_stress.c
>
> TARGETS = $(sources:.c=)
>
> @@ -79,7 +79,7 @@ svsematest: svsematest.o rt-utils.o rt-get_cpu.o
> sendme: sendme.o rt-utils.o rt-get_cpu.o
> $(CC) $(CFLAGS) -o $@ $^ $(LIBS) $(EXTRA_LIBS)
>
> -pip: pip.o error.o rt-utils.o
> +pip_stress: pip_stress.o error.o rt-utils.o
> $(CC) $(CFLAGS) -o $@ $^ $(LIBS)
>
> CLEANUP = $(TARGETS) *.o .depend *.*~ *.orig *.rej rt-tests.spec *.d
> diff --git a/src/include/pip.h b/src/include/pip_stress.h
> similarity index 93%
> rename from src/include/pip.h
> rename to src/include/pip_stress.h
> index b2068be..8ed2452 100644
> --- a/src/include/pip.h
> +++ b/src/include/pip_stress.h
> @@ -1,5 +1,5 @@
> -#ifndef __PIP_H
> -#define __PIP_H
> +#ifndef __PIP_STRESS_H
> +#define __PIP_STRESS_H
>
> #include <stdio.h>
> #include <stdlib.h>
> @@ -37,5 +37,4 @@ int get_rt_prio(pid_t pid);
> #define PROTRW PROT_READ|PROT_WRITE
> #define MMAP_FLAGS MAP_SHARED|MAP_ANONYMOUS
>
> -#endif /* __PIP_H */
> -
> +#endif /* __PIP_STRESS_H */
> diff --git a/src/pi_tests/pip.c b/src/pi_tests/pip_stress.c
> similarity index 98%
> rename from src/pi_tests/pip.c
> rename to src/pi_tests/pip_stress.c
> index 085908b..2b42b8f 100644
> --- a/src/pi_tests/pip.c
> +++ b/src/pi_tests/pip_stress.c
> @@ -1,6 +1,6 @@
> /*
> - Pip - Priority Inheritance with processes
> -
> + Pip stress - Priority Inheritance with processes
> +
> Copyright (C) 2009, John Kacur <jkacur@redhat.com>
>
> This program is free software: you can redistribute it and/or modify
> @@ -54,7 +54,7 @@
> * scheduling priorities.
> */
>
> -#include "pip.h"
> +#include "pip_stress.h"
>
> pthread_mutex_t *resource;
>
> @@ -107,7 +107,7 @@ int main(void)
> set_rt_prio(0, prio_min, policy);
>
> /* We restrict this program to the first cpu, inorder to increase
> - * the likelihood of a priority inversion */
> + * the likelihood of a priority inversion */
> CPU_ZERO(setp);
> CPU_SET(0, setp);
> res = sched_setaffinity(0, sizeof(set), setp);
> @@ -311,7 +311,7 @@ void init_shared_pthread_mutex(pthread_mutex_t *mutex, int protocol, int policy)
> Pthread_mutexattr_init(&attr);
> Pthread_mutexattr_setpshared(&attr, PTHREAD_PROCESS_SHARED);
> Pthread_mutexattr_setprotocol(&attr, protocol);
> -
> +
> Pthread_mutex_init(mutex, &attr);
> }
>
> --
> 1.7.0
I have no problem with this rename.
Signed-off-by: John Kacur <jkacur@redhat.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-03-01 19:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-02-25 20:24 [PATCH] rename pip to pip_stress as pip is too general Uwe Kleine-König
2010-03-01 16:51 ` Uwe Kleine-König
2010-03-01 19:40 ` John Kacur
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).