Re: [PATCH 2/2] remove-incorrect-options-from-smp-help-message-in-cyclictest.patch

[John Kacur <jkacur@redhat.com>]

On Mon, Mar 8, 2010 at 12:10 AM, John Kacur <jkacur@redhat.com> wrote:
> On Sun, Mar 7, 2010 at 9:39 PM, Carsten Emde <C.Emde@osadl.org> wrote:
>> The help message of cyclictest's -S option says that it equals -a -t -n -m -d0.
>> In reality, it only equals -a -t -n.
>>
>> Signed-off-by: Carsten Emde <C.Emde@osadl.org>
>>
>> Index: rt-tests/src/cyclictest/cyclictest.c
>> ===================================================================
>> --- rt-tests.orig/src/cyclictest/cyclictest.c
>> +++ rt-tests/src/cyclictest/cyclictest.c
>> @@ -777,8 +777,8 @@ static void display_help(int error)
>>                "-W       --wakeuprt        rt task wakeup tracing (used with -b)\n"
>>                "-y POLI  --policy=POLI     policy of realtime thread (1:FIFO, 2:RR)\n"
>>                "                           format: --policy=fifo(default) or --policy=rr\n"
>> -              "-S       --smp             Standard SMP testing (equals -a -t -n -m -d0)\n"
>> -               "                           same priority on all threads.\n"
>> +              "-S       --smp             Standard SMP testing: options -a -t -n and\n"
>> +               "                           same priority of all threads\n"
>>               "-U       --numa            Standard NUMA testing (similar to SMP option)\n"
>>                "                           thread data structures allocated from local node\n",
>>               tracers
>>
>> --
>
> Wow, you're right. I wonder if the intention here was to set -m and
> -d0 for -S, and if we instead need a patch to do exactly
> that if the user selects -S.
>
> Certainly a default of -d0 makes sense for smp, and it probably
> doesn't make sense to let the user override it either.
> However, I'm not sure if -m by default is a good choice to make for
> -S. I suggest we make -d0 the default for -S, and
> then see if anyone has an opinion about whether -m should be the
> default for -S. My vote is no, so then we would need
> to correct the documentation in that case.
>

Okay, looking at the history of cyclictest in git,
77abded073c5d11d118112c46c22a84ddc29e771
indicates that the intention was to set just -t -a and -n, so in that case
Acked-by: John Kacur <jkacur@redhat.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html