From: John Kacur <jkacur@redhat.com>
To: David Sommerseth <davids@redhat.com>
Cc: Carsten Emde <C.Emde@osadl.org>,
RT-users <linux-rt-users@vger.kernel.org>
Subject: Re: [PATCH 2/2] add-smp-option-to-svsematest.patch
Date: Tue, 9 Mar 2010 19:15:32 +0100 [thread overview]
Message-ID: <520f0cf11003091015i4c474939i8086cdd2bf98a438@mail.gmail.com> (raw)
In-Reply-To: <4B968F2B.4070708@redhat.com>
On Tue, Mar 9, 2010 at 7:10 PM, David Sommerseth <davids@redhat.com> wrote:
> On 07/03/10 21:48, Carsten Emde wrote:
>> - if (priority > 0)
>> + if (priority > 1 && !sameprio)
>> priority--;
>
> Unless I'm missing something really obvious, shouldn't this one state:
>
> if (priority > 0 && !sameprio)
> priority--;
>
> Or else 1 will be the lowest priority. It's a similar situation in
> "[PATCH 1/2] add-smp-option-to-ptsematest.patch" as well.
>
>
> kind regards,
>
> David Sommerseth
Carsten is the owner of this code, he may very will have intended that
1 be the lowest priority, so I didn't want to second guess him.
Carsten, is it useful to have SCHED_OTHER for this test?
Thanks
--
To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2010-03-09 18:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-07 20:48 [PATCH 0/2] [rt-tests] Add smp option to ptsematest and svsematest Carsten Emde
2010-03-07 20:48 ` [PATCH 1/2] add-smp-option-to-ptsematest.patch Carsten Emde
2010-03-08 12:45 ` John Kacur
2010-03-07 20:48 ` [PATCH 2/2] add-smp-option-to-svsematest.patch Carsten Emde
2010-03-08 12:45 ` John Kacur
2010-03-09 18:10 ` David Sommerseth
2010-03-09 18:15 ` John Kacur [this message]
2010-03-09 21:07 ` Carsten Emde
2010-03-09 20:39 ` Carsten Emde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=520f0cf11003091015i4c474939i8086cdd2bf98a438@mail.gmail.com \
--to=jkacur@redhat.com \
--cc=C.Emde@osadl.org \
--cc=davids@redhat.com \
--cc=linux-rt-users@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).