From: Ciprian Barbu <ciprian.barbu@linaro.org>
To: Clark Williams <williams@redhat.com>,
RT <linux-rt-users@vger.kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Linaro Networking <linaro-networking@linaro.org>
Subject: [PATCH] rt-tests: hackbench: fix for uninitialized start time
Date: Thu, 12 Dec 2013 16:47:19 +0200 [thread overview]
Message-ID: <52A9CC77.20904@linaro.org> (raw)
Hello,
While playing around with hackbench I discovered that I would sometimes
get an enormous time reported, even if the run time would be less than a
second or so. The problem was that the struct timeval start was not
initialized until after all children have been created. But if the
program receives a signal before this is done, the start time is left
uninitialized.
I propose that in such situations an error message be displayed, like
the following patch does.
Please let me know if this is acceptable.
Regards,
/Ciprian
---
diff -rupN rt-tests/src/hackbench/hackbench.c
rt-tests2/src/hackbench/hackbench.c
--- rt-tests/src/hackbench/hackbench.c 2013-12-12 16:27:06.273731063 +0200
+++ rt-tests2/src/hackbench/hackbench.c 2013-12-12 16:24:01.945738814 +0200
@@ -442,6 +442,7 @@ int main(int argc, char *argv[])
struct timeval start, stop, diff;
int readyfds[2], wakefds[2];
char dummy;
+ int timer_started = 0;
struct sched_param sp;
process_options (argc, argv);
@@ -490,6 +491,7 @@ int main(int argc, char *argv[])
}
gettimeofday(&start, NULL);
+ timer_started = 1;
/* Kick them off */
if (write(wakefds[1], &dummy, 1) != 1) {
@@ -509,8 +511,12 @@ int main(int argc, char *argv[])
gettimeofday(&stop, NULL);
/* Print time... */
- timersub(&stop, &start, &diff);
- printf("Time: %lu.%03lu\n", diff.tv_sec, diff.tv_usec/1000);
+ if (timer_started) {
+ timersub(&stop, &start, &diff);
+ printf("Time: %lu.%03lu\n", diff.tv_sec, diff.tv_usec/1000);
+ } else {
+ fprintf(stderr, "No measurements available\n");
+ }
free(child_tab);
exit(0);
}
next reply other threads:[~2013-12-12 14:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-12 14:47 Ciprian Barbu [this message]
2013-12-12 15:14 ` [PATCH] rt-tests: hackbench: fix for uninitialized start time Clark Williams
2013-12-12 20:29 ` 3.12.5 CRASH/FREEZE Pavel Vasilyev
2013-12-20 14:10 ` Sebastian Andrzej Siewior
2013-12-20 14:57 ` Pavel Vasilyev
2013-12-20 15:05 ` Sebastian Andrzej Siewior
2013-12-22 22:19 ` Pavel Vasilyev
2013-12-22 22:33 ` Pavel Vasilyev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52A9CC77.20904@linaro.org \
--to=ciprian.barbu@linaro.org \
--cc=linaro-networking@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).