From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Nicholas Mc Guire <der.herr@hofr.at>
Cc: linux-rt-users@vger.kernel.org
Subject: Re: bad return value in __mutex_lock_check_stamp
Date: Sun, 15 Dec 2013 16:10:11 +0100 [thread overview]
Message-ID: <52ADC653.7090005@linutronix.de> (raw)
In-Reply-To: <20131215144047.GB32756@opentech.at>
On 12/15/2013 03:40 PM, Nicholas Mc Guire wrote:
>
> Bad return value in _mutex_lock_check_stamp - this problem only would show
> up with 3.12.1 rt4 applied but CONFIG_PREEMPT_RT_FULL not enabled
> currently it would be returning what ever vprintk_emit ended up with
> (atleast on x86), which probably is not the intended behavior. Added a
> return 0; as in the case with CONFIG_PREEMPT_RT_FULL enabled.
Interesting. How do you trigger this? This BUG()-only function should
get completely removed by gcc because
- ctx argument should be always NULL
- BUG() has unreachable() so gcc knows it does not return.
Sebastian
next prev parent reply other threads:[~2013-12-15 15:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-15 14:40 bad return value in __mutex_lock_check_stamp Nicholas Mc Guire
2013-12-15 15:10 ` Sebastian Andrzej Siewior [this message]
2013-12-15 16:18 ` Nicholas Mc Guire
2013-12-15 16:48 ` Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52ADC653.7090005@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=der.herr@hofr.at \
--cc=linux-rt-users@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).