From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Steven Rostedt <rostedt@goodmis.org>,
linux-kernel@vger.kernel.org,
linux-rt-users <linux-rt-users@vger.kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Carsten Emde <C.Emde@osadl.org>, John Kacur <jkacur@redhat.com>,
Paul Gortmaker <paul.gortmaker@windriver.com>,
stable-rt@vger.kernel.org
Subject: Re: [PATCH RT 2/4] net: gianfar: do not try to cleanup TX packets if they are not done
Date: Mon, 28 Apr 2014 08:37:56 +0200 [thread overview]
Message-ID: <535DF744.60606@linutronix.de> (raw)
In-Reply-To: <20140427143140.384915886@goodmis.org>
On 04/27/2014 04:31 PM, Steven Rostedt wrote:
> diff --git a/drivers/net/ethernet/freescale/gianfar.c b/drivers/net/ethernet/freescale/gianfar.c
> index 5c0efcc..8aecc1d 100644
> --- a/drivers/net/ethernet/freescale/gianfar.c
> +++ b/drivers/net/ethernet/freescale/gianfar.c
> @@ -2856,10 +2855,14 @@ static int gfar_poll(struct napi_struct *napi, int budget)
> tx_queue = priv->tx_queue[i];
> /* run Tx cleanup to completion */
> if (tx_queue->tx_skbuff[tx_queue->skb_dirtytx]) {
> - gfar_clean_tx_ring(tx_queue);
> - has_tx_work = 1;
> + int ret;
> +
> + ret = gfar_clean_tx_ring(tx_queue);
> + if (ret)
> + has_tx_work++;
> }
> }
> + work_done += has_tx_work;
>
> for_each_set_bit(i, &gfargrp->rx_bit_map, priv->num_rx_queues) {
> /* skip queue if not active */
The 3.14-RT version of the patch should have an additional return
statement here which I forgot initially.
Sebastian
next prev parent reply other threads:[~2014-04-28 6:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-27 14:31 [PATCH RT 0/4] Linux 3.10.37-rt38-rc1 Steven Rostedt
2014-04-27 14:31 ` [PATCH RT 1/4] net: gianfar: do not disable interrupts Steven Rostedt
2014-04-27 14:31 ` [PATCH RT 2/4] net: gianfar: do not try to cleanup TX packets if they are not done Steven Rostedt
2014-04-28 6:37 ` Sebastian Andrzej Siewior [this message]
2014-04-29 14:16 ` Paul Gortmaker
2014-04-29 14:25 ` Steven Rostedt
2014-04-27 14:31 ` [PATCH RT 3/4] rcu: make RCU_BOOST default on RT Steven Rostedt
2014-04-27 14:31 ` [PATCH RT 4/4] Linux 3.10.37-rt38-rc1 Steven Rostedt
-- strict thread matches above, loose matches on Subject: below --
2014-04-29 14:30 [PATCH RT 0/4] Linux 3.10.37-rt38-rc2 Steven Rostedt
2014-04-29 14:31 ` [PATCH RT 2/4] net: gianfar: do not try to cleanup TX packets if they are not done Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=535DF744.60606@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=C.Emde@osadl.org \
--cc=jkacur@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=rostedt@goodmis.org \
--cc=stable-rt@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).