From: Daniel Wagner <wagi@monom.org>
To: Juri Lelli <juri.lelli@arm.com>,
Daniel Wagner <daniel.wagner@bmw-carit.de>,
"juri.lelli@gmail.com" <juri.lelli@gmail.com>
Cc: "linux-rt-users@vger.kernel.org" <linux-rt-users@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: [PATCH] sched: Do not try to replenish from a non deadline tasks
Date: Tue, 07 Oct 2014 14:02:28 +0200 [thread overview]
Message-ID: <5433D654.2020108@monom.org> (raw)
In-Reply-To: <5433B5B9.70006@arm.com>
Hi Juri,
On 10/07/2014 11:43 AM, Juri Lelli wrote:
> Hi Daniel,
>
> On 24/09/14 14:24, Daniel Wagner wrote:
>> When a PI mutex is shared between an deadline task and normal task we
>> might end up trying to replenish from the normal task. In this case neither
>> dl_runtime, dl_period or dl_deadline are set. replenish_dl_entity() can't do
>> anything useful.
>>
>
> Is this same bug we have with rt_mutex_setprio or something different?
> I'm sorry, but I don't remember anymore :/. It looks like a different
> issue, though.
There are two independent bugs but in both cases BUG_ON in
enqueue_dl_entity() is triggered.
The first one (this patch) is triggered by trying to use the sched_attr
of the non deadline task. The second one is the double queuing.
> Anyway, the callpath you talked about on IRC seems to make sense, does
> what below fix the thing?
I'll give it a spin.
> Could you please point me again to where the
> tests you are running are hosted, so that I can easily reproduce the
> bug here?
Sure. I reduced my original program to this:
http://www.monom.org/rt/pthread_test.c
If you let it run with 'pthread_test inherit' you should see the bugs
eventually.
cheers,
daniel
next prev parent reply other threads:[~2014-10-07 12:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-24 13:24 [PATCH] sched: Do not try to replenish from a non deadline tasks Daniel Wagner
2014-10-07 9:43 ` Juri Lelli
2014-10-07 12:02 ` Daniel Wagner [this message]
2014-10-07 12:10 ` Daniel Wagner
2014-10-07 13:20 ` Daniel Wagner
2014-10-09 9:47 ` Daniel Wagner
2014-10-09 13:51 ` Juri Lelli
2014-10-10 8:17 ` Daniel Wagner
2014-10-09 13:48 ` Juri Lelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5433D654.2020108@monom.org \
--to=wagi@monom.org \
--cc=daniel.wagner@bmw-carit.de \
--cc=juri.lelli@arm.com \
--cc=juri.lelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).