linux-rt-users.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: linuxball <linuxball@gmail.com>
To: linux-rt-users <linux-rt-users@vger.kernel.org>
Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	Steven Rostedt <rostedt@goodmis.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Carsten Emde <C.Emde@osadl.org>, John Kacur <jkacur@redhat.com>
Subject: Re: [PATCH 1/1] 3.18.17-rt14 locktorture: Do NOT include rwlock.h directly
Date: Tue, 21 Jul 2015 16:20:07 +0200	[thread overview]
Message-ID: <55AE5517.9040403@gmail.com> (raw)
In-Reply-To: <20150720154753.GC9559@linutronix.de>

Including rwlock.h directly will cause kernel builds to fail
if CONFIG_PREEMPT_RT_FULL is defined. The correct header file
(rwlock_rt.h OR rwlock.h) will be included by spinlock.h which
is included by locktorture.c anyway.

Signed-off-by: Wolfgang M. Reimer <linuxball@gmail.com>
---
  kernel/locking/locktorture.c | 1 -
  1 file changed, 1 deletion(-)

diff --git a/kernel/locking/locktorture.c b/kernel/locking/locktorture.c
index ec8cce2..aa60d91 100644
--- a/kernel/locking/locktorture.c
+++ b/kernel/locking/locktorture.c
@@ -24,7 +24,6 @@
  #include <linux/module.h>
  #include <linux/kthread.h>
  #include <linux/spinlock.h>
-#include <linux/rwlock.h>
  #include <linux/mutex.h>
  #include <linux/rwsem.h>
  #include <linux/smp.h>
-- 
1.9.1

On 20.07.2015 17:47, Sebastian Andrzej Siewior wrote:
> * linuxball | 2015-07-20 11:33:12 [+0200]:
>
>> Including rwlock.h directly will cause kernel builds to fail
>> if CONFIG_PREEMPT_RT_FULL is defined. The correct header file
>> (rwlock_rt.h OR rwlock.h) will be included by spinlock.h which
>> is included by locktorture.c anyway.
> Documentation/SubmittingPatches:
>      11) Sign your work
>
> Sebastian


  reply	other threads:[~2015-07-21 14:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-02 19:25 [ANNOUNCE] 3.18.17-rt14 Steven Rostedt
2015-07-20  9:33 ` [PATCH 1/1] 3.18.17-rt14 locktorture: Do NOT include rwlock.h directly linuxball
2015-07-20 15:47   ` Sebastian Andrzej Siewior
2015-07-21 14:20     ` linuxball [this message]
2015-07-21 16:45       ` Sebastian Andrzej Siewior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55AE5517.9040403@gmail.com \
    --to=linuxball@gmail.com \
    --cc=C.Emde@osadl.org \
    --cc=bigeasy@linutronix.de \
    --cc=jkacur@redhat.com \
    --cc=linux-rt-users@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).