From: Sebastian Andrzej Siewior <bigeasy-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
To: Lars-Peter Clausen <lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>,
Xander Huff <xander.huff-acOepvfBmUk@public.gmane.org>,
jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org
Cc: knaack.h-Mmb7MZpHnFY@public.gmane.org,
pmeerw-jW+XmwGofnusTnJN9+BGXg@public.gmane.org,
michal.simek-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org,
soren.brinkmann-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org,
linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-rt-users-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
joe.hershberger-acOepvfBmUk@public.gmane.org,
joshc-acOepvfBmUk@public.gmane.org,
nathan.sullivan-acOepvfBmUk@public.gmane.org,
jaeden.amero-acOepvfBmUk@public.gmane.org
Subject: Re: [PATCH v4] iio: adc: xilinx-xadc: Push interrupts into hardirq context
Date: Wed, 12 Aug 2015 18:33:28 +0200 [thread overview]
Message-ID: <55CB7558.3090608@linutronix.de> (raw)
In-Reply-To: <55CB6391.7060502-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>
On 08/12/2015 05:17 PM, Lars-Peter Clausen wrote:
> On 08/12/2015 01:00 AM, Xander Huff wrote:
>> Unfortunately, this breaks PREEMPT_RT builds, where a spinlock can sleep,
>> and is thus not able to be acquired from a hardirq handler. This patch gets
>> rid of the threaded handler and pushes all interrupt handling into the
>> hardirq context, and uses request_irq().
>>
>> To validate that this change has no impact on RT performance, here are
>> cyclictest values with no processes running:
>
> Looks good, thanks.
>
> Acked-by: Lars-Peter Clausen <lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>
Yes, I'm fine with the rework, too.
Sebastian
next prev parent reply other threads:[~2015-08-12 16:33 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-07 15:38 [PATCH] iio: adc: xilinx-xadc: Convert to raw spinlock Xander Huff
[not found] ` <1431013090-18996-1-git-send-email-xander.huff-acOepvfBmUk@public.gmane.org>
2015-05-14 17:10 ` Sebastian Andrzej Siewior
[not found] ` <20150514171038.GG13442-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
2015-05-14 22:45 ` Xander Huff
[not found] ` <55552570.5050407-acOepvfBmUk@public.gmane.org>
2015-05-18 21:17 ` Sebastian Andrzej Siewior
2015-05-23 11:36 ` Jonathan Cameron
[not found] ` <20150518211728.GC4275-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
2015-06-07 15:29 ` Jonathan Cameron
[not found] ` <5574633F.7090004-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2015-06-08 14:44 ` Xander Huff
2015-07-08 21:38 ` [PATCH v2] iio: adc: xilinx-xadc: Push interrupts into threaded context Xander Huff
2015-07-14 14:28 ` Sebastian Andrzej Siewior
2015-07-15 15:59 ` Xander Huff
[not found] ` <CAKfKVtGTO81wLWk50M303t2WjcBEMEt_LUnsJ3_WmvR_3izUjg@mail.gmail.com>
[not found] ` <CAKfKVtGTO81wLWk50M303t2WjcBEMEt_LUnsJ3_WmvR_3izUjg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-07-15 15:57 ` Xander Huff
2015-07-20 23:14 ` [PATCH v3] " Xander Huff
[not found] ` <1437434050-32907-1-git-send-email-xander.huff-acOepvfBmUk@public.gmane.org>
2015-07-24 12:38 ` Lars-Peter Clausen
[not found] ` <55B231DE.4080308-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>
2015-08-03 20:18 ` Xander Huff
[not found] ` <55BFCC9C.5040305-acOepvfBmUk@public.gmane.org>
2015-08-04 8:01 ` Lars-Peter Clausen
2015-08-11 23:00 ` [PATCH v4] iio: adc: xilinx-xadc: Push interrupts into hardirq context Xander Huff
[not found] ` <1439334049-28671-1-git-send-email-xander.huff-acOepvfBmUk@public.gmane.org>
2015-08-12 15:17 ` Lars-Peter Clausen
[not found] ` <55CB6391.7060502-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>
2015-08-12 16:33 ` Sebastian Andrzej Siewior [this message]
[not found] ` <55CB7558.3090608-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
2015-08-15 19:55 ` Jonathan Cameron
2015-08-04 5:34 ` [PATCH v3] iio: adc: xilinx-xadc: Push interrupts into threaded context Shubhrajyoti Datta
[not found] ` <CAKfKVtGegy2P_YWQAtKEzByN-+q+bq=uus4zNvO4sghXRjpGPQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-08-04 8:05 ` Lars-Peter Clausen
[not found] ` <55C0722C.7080904-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>
2015-08-07 3:55 ` Shubhrajyoti Datta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55CB7558.3090608@linutronix.de \
--to=bigeasy-hfztesqfncyowbw4kg4ksq@public.gmane.org \
--cc=jaeden.amero-acOepvfBmUk@public.gmane.org \
--cc=jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=joe.hershberger-acOepvfBmUk@public.gmane.org \
--cc=joshc-acOepvfBmUk@public.gmane.org \
--cc=knaack.h-Mmb7MZpHnFY@public.gmane.org \
--cc=lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-rt-users-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=michal.simek-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org \
--cc=nathan.sullivan-acOepvfBmUk@public.gmane.org \
--cc=pmeerw-jW+XmwGofnusTnJN9+BGXg@public.gmane.org \
--cc=soren.brinkmann-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org \
--cc=xander.huff-acOepvfBmUk@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).