From: Carsten Emde <C.Emde@osadl.org>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Steven Rostedt <rostedt@goodmis.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Linux RT Users <linux-rt-users@vger.kernel.org>
Subject: Re: trace/latency-hist: Consider new argument when probing the sched_switch tracer
Date: Fri, 15 Jan 2016 12:30:55 +0100 [thread overview]
Message-ID: <5698D86F.607@osadl.org> (raw)
In-Reply-To: <56967681.9070204@linutronix.de>
Hi Sebastian, hi Steven,
>>> [..] What is blocking the latency-hist tracer from entering
>>> mainline?
>>
>> Has it been submitted. Like lots of things in -rt, it just takes
>> the effort of pushing out an RFC for inclusion.
>
> Not that I recall. But this means that there is nothing specific
> that you are aware of that needs to be changed before RFC.
>
> So, Carsten do you mind taking the latency-hist patch and submitting
> it as RFC for upstream inclusion?
There are two things here:
1. The sum of the timer latency and the wakeup latency does not completely
cover the total preemption latency as, for example, determined by cyclictest.
The time of the context switch until the new task resumes execution at the
next line after the wait instruction is still lacking. I wrote a related
patch sometime ago that is working since then in numerous farm systems -
but I never posted the patch of this switchtime histogram, because someone
said that we first need to re-engineer the histogram code in general.
Nevertheless, I used the opportunity of your posting to submit the patch in
a separate thread so you can have a look. As a bonus, the name of the
delayed system call that caused the highest latency until then is provided
when the switchtime histogram is enabled - this may or may not be helpful
when searching for the source of a latency.
2. The idea behind re-engineering the histogram code someone proposed several
years ago is to create a general framework that can be used throughout the
kernel (or even from user space through a dedicated tracer interface) for any
variable the frequency distribution of which is of interest and that would
best be monitored in form of a frequency histogram - such as a latency
distribution. The various latency tracers would then serve as a practical
example of how to use this fancy new framework. I let you guess why this
re-engineering did not yet happen.
So the question is whether you still encourage me to write the RFC for
upstream inclusion of the current code after some polishing - maybe, in the
hope that someone will come up with the framework during RFC discussion -
or we better wait, since writing an RFC for hopeless code really doesn't
make sense.
Thanks,
-Carsten.
next prev parent reply other threads:[~2016-01-15 11:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-05 9:21 trace/latency-hist: Consider new argument when probing the sched_switch tracer Carsten Emde
2016-01-13 15:45 ` Sebastian Andrzej Siewior
2016-01-13 15:51 ` Steven Rostedt
2016-01-13 16:08 ` Sebastian Andrzej Siewior
2016-01-15 11:30 ` Carsten Emde [this message]
2016-01-15 14:05 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5698D86F.607@osadl.org \
--to=c.emde@osadl.org \
--cc=bigeasy@linutronix.de \
--cc=linux-rt-users@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).