From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sebastian Andrzej Siewior Subject: Re: [rfc patch v4.4-rt2] sched: fix up preempt lazy forward port Date: Fri, 22 Jan 2016 13:54:43 +0100 Message-ID: <56A22693.4020304@linutronix.de> References: <1453108103.4123.4.camel@gmail.com> <20160118201828.GE12309@linutronix.de> <56A2196E.1020101@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Thomas Gleixner , LKML , linux-rt-users To: Grygorii Strashko , Mike Galbraith Return-path: Received: from www.linutronix.de ([62.245.132.108]:45863 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753402AbcAVMyp (ORCPT ); Fri, 22 Jan 2016 07:54:45 -0500 In-Reply-To: <56A2196E.1020101@ti.com> Sender: linux-rt-users-owner@vger.kernel.org List-ID: On 01/22/2016 12:58 PM, Grygorii Strashko wrote: > On 01/18/2016 10:18 PM, Sebastian Andrzej Siewior wrote: >> * Mike Galbraith | 2016-01-18 10:08:23 [+0100]: >> >>> --- a/arch/x86/entry/common.c >>> +++ b/arch/x86/entry/common.c >>> @@ -220,14 +220,14 @@ long syscall_trace_enter(struct pt_regs >>> >>> #define EXIT_TO_USERMODE_LOOP_FLAGS \ >>> (_TIF_SIGPENDING | _TIF_NOTIFY_RESUME | _TIF_UPROBE | \ >>> - _TIF_NEED_RESCHED | _TIF_USER_RETURN_NOTIFY) >>> + _TIF_NEED_RESCHED_MASK | _TIF_USER_RETURN_NOTIFY) >> >> If I read this right, the loop where this define is used >> _TIF_ALLWORK_MASK in v4.1 of which _TIF_NEED_RESCHED_MASK was part o= f. >> Adding this will reassmeble the old behaviour. >> =E2=80=A6 >=20 > Just a question (sorry if dumb). ARM has _TIF_WORK_MASK defined: > #define _TIF_WORK_MASK (_TIF_NEED_RESCHED | _TIF_SIGPENDING | \ > _TIF_NOTIFY_RESUME | _TIF_UPROBE) >=20 > which is used to calculate loop exit condition in > do_work_pending() (arch/arm/kernel/signal.c). >=20 > Should _TIF_WORK_MASK also contain _TIF_NEED_RESCHED_LAZY? Yes, and arm64 lacks the same bits. Sebastian -- To unsubscribe from this list: send the line "unsubscribe linux-rt-user= s" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html