From: "Shi, Yang" <yang.shi@linaro.org>
To: Tejun Heo <tj@kernel.org>, Thomas Gleixner <tglx@linutronix.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Li Zefan <lizefan@huawei.com>,
Steven Rostedt <rostedt@goodmis.org>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
lkml <linux-kernel@vger.kernel.org>,
linux-rt-users@vger.kernel.org,
Lists linaro-kernel <linaro-kernel@lists.linaro.org>,
hch@infradead.org
Subject: Re: [RFC V2 PATCH] kernfs: create raw version kernfs_path_len and kernfs_path
Date: Mon, 29 Feb 2016 10:00:53 -0800 [thread overview]
Message-ID: <56D48755.9070604@linaro.org> (raw)
In-Reply-To: <CAOS58YNAgyCcepowr=gFrL+dZZ04ua-zLUtsOY6qGh=+_J52_w@mail.gmail.com>
On 2/27/2016 3:51 AM, Tejun Heo wrote:
> Hello,
>
> On Sat, Feb 27, 2016 at 6:45 AM, Thomas Gleixner <tglx@linutronix.de> wrote:
>>> It can be, but we can print out the ino and userland can match that up
>>> with path if necessary.
>>
>> Wouldn't be cgroup id the better choice?
>
> AFAIK we aren't exposing cgroup id to userland anywhere right now.
> Eventually, I think the right thing to do is using the same number for
> both.
Thanks for all the comments.
Since the current tracepoints print the path length too by
__trace_wb_cgroup_size and __trace_wbc_cgroup_size, but we can't get the
path length if we switch to group ino. So, I'm supposed I have to drop
all the *_size stuff.
And, when CONFIG_CGROUP_WRITEBACK is not enabled,
__trace_wb_assign_cgroup and __trace_wbc_assign_cgroup return
"strcpy(buf, "/")", so to get aligned with this, I need print out the
ino of "/", right? But, the ROOT_INO may vary from different filesystems.
All of them will be addressed in V4, but it may experience some delay
since I have to travel this week.
Regards,
Yang
>
> Thanks.
>
prev parent reply other threads:[~2016-02-29 18:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-26 21:47 [RFC V2 PATCH] kernfs: create raw version kernfs_path_len and kernfs_path Yang Shi
2016-02-26 23:01 ` Greg KH
2016-02-26 23:05 ` Shi, Yang
2016-02-27 8:52 ` Christoph Hellwig
2016-02-27 11:17 ` Tejun Heo
2016-02-27 11:37 ` Thomas Gleixner
2016-02-27 11:41 ` Tejun Heo
2016-02-27 11:45 ` Thomas Gleixner
2016-02-27 11:51 ` Tejun Heo
2016-02-29 18:00 ` Shi, Yang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56D48755.9070604@linaro.org \
--to=yang.shi@linaro.org \
--cc=bigeasy@linutronix.de \
--cc=gregkh@linuxfoundation.org \
--cc=hch@infradead.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).