From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Sean_Nyekj=c3=a6r?= Subject: Re: [PATCH] tty: serial: sc16is7xx: use threaded interrupts instead of homegrow Date: Wed, 9 Mar 2016 08:03:06 +0100 Message-ID: <56DFCAAA.3090807@prevas.dk> References: <56CDCCE6.5020801@prevas.dk> <56CDEAE2.9050102@prevas.dk> <20160224223547.GF9598@jcartwri.amer.corp.natinst.com> <20160226114340.GC8318@linutronix.de> <20160226114809.GD8318@linutronix.de> <20160226165228.GA17178@jcartwri.amer.corp.natinst.com> <835668C1-5DDB-4495-AD00-4EE8DDD0D146@wp.pl> <20160226190048.GC12917@jcartwri.amer.corp.natinst.com> <56DDAF2A.2000009@linutronix.de> <20160307165809.GC28102@jcartwri.amer.corp.natinst.com> <20160308211845.57e9796a@laptop> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Cc: Sebastian Andrzej Siewior , Greg Kroah-Hartman , , , Jon Ringle , Thomas Gleixner To: Jakub Kicinski , Josh Cartwright Return-path: Received: from mail02.prevas.se ([62.95.78.10]:22625 "EHLO mail02.prevas.se" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750902AbcCIHDM (ORCPT ); Wed, 9 Mar 2016 02:03:12 -0500 In-Reply-To: <20160308211845.57e9796a@laptop> Sender: linux-rt-users-owner@vger.kernel.org List-ID: On 2016-03-08 22:18, Jakub Kicinski wrote: > On Mon, 7 Mar 2016 10:58:09 -0600, Josh Cartwright wrote: >>> I got lost here. Where do we stand here now? >> I understood the comment from Kuba to mean that he would be implementing >> the disable_irq()/enable_irq() idea above to fix all the problems with >> this driver. >> >> Kuba- did I read that right? > I was hoping Sean or someone else would take up this task ;) Yes i could try :-) At least i have a working setup with the hardware. > > It should be a pretty simple patch. > > Kuba I not entirely sure what i have to do... - Reenable the ONE_SHOT - Disable irq when running in the loop, and enable when returning? - Implement threaded irq? /Sean