From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Sean_Nyekj=c3=a6r?= Subject: Re: [PATCH] tty: serial: sc16is7xx: implemented our own oneshot-like handling Date: Fri, 11 Mar 2016 11:36:42 +0100 Message-ID: <56E29FBA.1060306@prevas.dk> References: <1457692476-19082-1-git-send-email-sean.nyekjaer@prevas.dk> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Cc: Josh Cartwright , Greg Kroah-Hartman , , Jon Ringle , Thomas Gleixner To: Return-path: Received: from mail01.prevas.se ([62.95.78.3]:24565 "EHLO mail01.prevas.se" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751369AbcCKKgo (ORCPT ); Fri, 11 Mar 2016 05:36:44 -0500 In-Reply-To: <1457692476-19082-1-git-send-email-sean.nyekjaer@prevas.dk> Sender: linux-rt-users-owner@vger.kernel.org List-ID: On 2016-03-11 11:34, Sean Nyekjaer wrote: > Signed-off-by: Sean Nyekjaer > --- > This patch depends on patch "sc16is7xx: drop bogus use of IRQF_ONESHOT" > > drivers/tty/serial/sc16is7xx.c | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/drivers/tty/serial/sc16is7xx.c b/drivers/tty/serial/sc16is7xx.c > index 73d46e2..96d1f3e 100644 > --- a/drivers/tty/serial/sc16is7xx.c > +++ b/drivers/tty/serial/sc16is7xx.c > @@ -706,13 +706,20 @@ static void sc16is7xx_ist(struct kthread_work *ws) > struct sc16is7xx_port *s = to_sc16is7xx_port(ws, irq_work); > int i; > > - for (i = 0; i < s->devtype->nr_uart; ++i) > + for (i = 0; i < s->devtype->nr_uart; ++i) { > sc16is7xx_port_irq(s, i); > + enable_irq(s->p[i].port.irq); > + } > + Ops one-line break to much :-( Waiting for other comments before fixing :-) /Sean > } > > static irqreturn_t sc16is7xx_irq(int irq, void *dev_id) > { > struct sc16is7xx_port *s = (struct sc16is7xx_port *)dev_id; > + int i; > + > + for (i = 0; i < s->devtype->nr_uart; ++i) > + disable_irq_nosync(s->p[i].port.irq); > > queue_kthread_work(&s->kworker, &s->irq_work); >