Re: [PATCH] rteval: Introduce E2E tests with output checking

[Crystal Wood <crwood@redhat.com>]

On Fri, 2025-09-26 at 13:09 +0200, Tomas Glozar wrote:
> čt 18. 9. 2025 v 21:22 odesílatel Crystal Wood <crwood@redhat.com> napsal:
> > 
> > Can we just put all the tests in tests/ rather than making this
> > distinction?  And have the unit tests be something that can be run just
> > like any other test?
> > 
> 
> I agree that the organization is not the best. This patch only deals
> with end-to-end tests, though. As long as there is a top-level
> unit-tests/ directory, adding another one named tests/ would be
> confusing.

I was suggesting putting *all* tests in a single tests/ directory,
including the unit tests.  So, there wouldn't be a unit-tests/
directory.

> 
> > > +             if [ $exitcode -eq $expected_exitcode ] && [ $grep_result -eq 0 ]
> > > +             then
> > > +                     echo "ok $ctr - $1"
> > > +             else
> > > +                     echo "not ok $ctr - $1"
> > > +                     # Add rtla output and exit code as comments in case of failure
> > > +                     echo "$result" | col -b | while read line; do echo "# $line"; done
> > > +                     printf "#\n# exit code %s\n" $exitcode
> > > +                     [ -n "$expected_output" ] && [ $grep_result -ne 0 ] && \
> > > +                             printf "# Output match failed: \"%s\"\n" "$expected_output"
> > > +             fi
> > 
> > Any reason to not take the updated version of the engine from the rtla
> > consolidation patchset?
> > 
> 
> This patch was sent quite some time ago, I think it was before the
> updated version of the engine.

Ah, I thought it was a new patch, not a reply to an older patch.


-Crystal