linux-rt-users.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] cyclictest: new CPUs with SMI counter support
@ 2016-05-30 22:25 Daniel Bristot de Oliveira
  2016-05-31  8:47 ` John Kacur
  0 siblings, 1 reply; 3+ messages in thread
From: Daniel Bristot de Oliveira @ 2016-05-30 22:25 UTC (permalink / raw)
  To: John Kacur, Clark Williams; +Cc: linux-rt-users

Cyclictest's SMI counter implementation is based on turbostat's
implementation. This patch syncs cyclictest's has_smi_counter()
with turbostat's check.

>From turbostat's commits:
cdc5727 tools/power turbostat: initial KBL support
ec53e59 tools/power turbostat: initial SKX support
e4085d5 tools/power turbostat: initial BXT support

[ John & Clark, I did it in the branch devel/v2.0, but we need  ]
[ this in the 0.x and 1.x series as well.                       ]

Signed-off-by: Daniel Bristot de Oliveira <bristot@redhat.com>
---
 src/cyclictest/cyclictest.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/src/cyclictest/cyclictest.c b/src/cyclictest/cyclictest.c
index 00e5f3d..5e23fc5 100644
--- a/src/cyclictest/cyclictest.c
+++ b/src/cyclictest/cyclictest.c
@@ -927,10 +927,14 @@ static int has_smi_counter(void)
 	case 0x56:      /* BDX-DE */
 	case 0x4E:      /* SKL */
 	case 0x5E:      /* SKL */
+	case 0x8E:      /* KBL */
+	case 0x9E:      /* KBL */
+	case 0x55:      /* SKX */
 	case 0x37:      /* BYT */
 	case 0x4D:      /* AVN */
 	case 0x4C:      /* AMT */
 	case 0x57:      /* PHI */
+	case 0x5C:      /* BXT */
 		break;
 	default:
 		return 0;
-- 
2.5.5


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] cyclictest: new CPUs with SMI counter support
  2016-05-30 22:25 [PATCH] cyclictest: new CPUs with SMI counter support Daniel Bristot de Oliveira
@ 2016-05-31  8:47 ` John Kacur
  2016-05-31 11:31   ` Daniel Bristot de Oliveira
  0 siblings, 1 reply; 3+ messages in thread
From: John Kacur @ 2016-05-31  8:47 UTC (permalink / raw)
  To: Daniel Bristot de Oliveira; +Cc: Clark Williams, linux-rt-users



On Mon, 30 May 2016, Daniel Bristot de Oliveira wrote:

> Cyclictest's SMI counter implementation is based on turbostat's
> implementation. This patch syncs cyclictest's has_smi_counter()
> with turbostat's check.
> 
> From turbostat's commits:
> cdc5727 tools/power turbostat: initial KBL support
> ec53e59 tools/power turbostat: initial SKX support
> e4085d5 tools/power turbostat: initial BXT support
> 
> [ John & Clark, I did it in the branch devel/v2.0, but we need  ]
> [ this in the 0.x and 1.x series as well.                       ]
> 
> Signed-off-by: Daniel Bristot de Oliveira <bristot@redhat.com>
> ---
>  src/cyclictest/cyclictest.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/src/cyclictest/cyclictest.c b/src/cyclictest/cyclictest.c
> index 00e5f3d..5e23fc5 100644
> --- a/src/cyclictest/cyclictest.c
> +++ b/src/cyclictest/cyclictest.c
> @@ -927,10 +927,14 @@ static int has_smi_counter(void)
>  	case 0x56:      /* BDX-DE */
>  	case 0x4E:      /* SKL */
>  	case 0x5E:      /* SKL */
> +	case 0x8E:      /* KBL */
> +	case 0x9E:      /* KBL */
> +	case 0x55:      /* SKX */
>  	case 0x37:      /* BYT */
>  	case 0x4D:      /* AVN */
>  	case 0x4C:      /* AMT */
>  	case 0x57:      /* PHI */
> +	case 0x5C:      /* BXT */
>  		break;
>  	default:
>  		return 0;
> -- 
I applied the patch to both the stable and devel branches. I slightly 
modified the commit message to read.

"    Cyclictest's SMI counter implementation is based on the turbostat
    tool in the Linux kernel.  This patch syncs cyclictest's 
    has_smi_counter() with turbostat's check.
"

Signed-off-by: John Kacur <jkacur@redhat.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] cyclictest: new CPUs with SMI counter support
  2016-05-31  8:47 ` John Kacur
@ 2016-05-31 11:31   ` Daniel Bristot de Oliveira
  0 siblings, 0 replies; 3+ messages in thread
From: Daniel Bristot de Oliveira @ 2016-05-31 11:31 UTC (permalink / raw)
  To: John Kacur; +Cc: Clark Williams, linux-rt-users

On 05/31/2016 05:47 AM, John Kacur wrote:
> I applied the patch to both the stable and devel branches. I slightly 
> modified the commit message to read.

Perfect! Thanks, John.

-- Daniel

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-05-31 11:31 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-30 22:25 [PATCH] cyclictest: new CPUs with SMI counter support Daniel Bristot de Oliveira
2016-05-31  8:47 ` John Kacur
2016-05-31 11:31   ` Daniel Bristot de Oliveira

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).