From: Valdis.Kletnieks@vt.edu
To: frank.rowand@am.sony.com
Cc: tglx@linutronix.de, linux-rt-users@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2] preempt-rt: allow immediate Magic SysRq output for PREEMPT_RT_FULL
Date: Fri, 23 Sep 2011 13:36:17 -0400 [thread overview]
Message-ID: <7186.1316799377@turing-police.cc.vt.edu> (raw)
In-Reply-To: Your message of "Thu, 22 Sep 2011 14:05:56 PDT." <4E7BA334.2050003@am.sony.com>
[-- Attachment #1: Type: text/plain, Size: 1116 bytes --]
On Thu, 22 Sep 2011 14:05:56 PDT, Frank Rowand said:
> Change from V1 to V2: add drivers/tty/serial/8250.c
> drivers/tty/serial/cpm_uart/cpm_uart_core.c | 2 1 + 1 - 0 !
> drivers/tty/serial/mfd.c | 2 1 + 1 - 0 !
> drivers/tty/serial/nwpserial.c | 2 1 + 1 - 0 !
> drivers/tty/serial/omap-serial.c | 2 1 + 1 - 0 !
> drivers/tty/serial/sunhv.c | 4 2 + 2 - 0 !
> drivers/tty/serial/sunsab.c | 2 1 + 1 - 0 !
> drivers/tty/serial/sunsu.c | 2 1 + 1 - 0 !
> drivers/tty/serial/sunzilog.c | 2 1 + 1 - 0 !
> drivers/tty/serial/uartlite.c | 2 1 + 1 - 0 !
> drivers/tty/serial/xilinx_uartps.c | 2 1 + 1 - 0 !
> if (up->port.sysrq)
> locked = 0;
> - else if (oops_in_progress) {
> + else if (oops_in_progress || sysrq_in_progress) {
> locked = spin_trylock(&up->port.lock);
> } else
> spin_lock(&up->port.lock);
Is it time to create a helper function for this chunk of code that appears
in almost identical form in a dozen drivers?
[-- Attachment #2: Type: application/pgp-signature, Size: 227 bytes --]
next prev parent reply other threads:[~2011-09-23 17:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-22 21:05 [PATCH V2] preempt-rt: allow immediate Magic SysRq output for PREEMPT_RT_FULL Frank Rowand
2011-09-23 17:36 ` Valdis.Kletnieks [this message]
2011-09-23 20:15 ` Frank Rowand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7186.1316799377@turing-police.cc.vt.edu \
--to=valdis.kletnieks@vt.edu \
--cc=frank.rowand@am.sony.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox