From: Steffen Trumtrar <s.trumtrar@pengutronix.de>
To: linux-watchdog@vger.kernel.org
Cc: Wim Van Sebroeck <wim@linux-watchdog.org>,
Guenter Roeck <linux@roeck-us.net>,
Christophe Leroy <christophe.leroy@c-s.fr>,
linux-rt-users@vger.kernel.org
Subject: [BUG] dw_wdt watchdog on linux-rt 4.18.5-rt4 not triggering
Date: Tue, 18 Sep 2018 15:21:08 +0200 [thread overview]
Message-ID: <73d0tbdjqz.fsf@pengutronix.de> (raw)
Hi all!
I'm seeing an issue with the dw_wdt watchdog on the SoCFPGA ARM
platform with the latest linux-rt v4.18.5-rt4. Actually I seem to
have the same problem, that these patches try to fix:
38a1222ae4f364d5bd5221fe305dbb0889f45d15
Author: Christophe Leroy <christophe.leroy@c-s.fr>
AuthorDate: Fri Dec 8 11:18:35 2017 +0100
Commit: Wim Van Sebroeck <wim@iguana.be>
CommitDate: Thu Dec 28 20:45:57 2017 +0100
Follows: v4.15-rc3 (345)
Precedes: v4.16-rc1 (13997)
watchdog: core: make sure the watchdog worker always works
When running a command like 'chrt -f 50 dd if=/dev/zero
of=/dev/null',
the watchdog_worker fails to service the HW watchdog and the
HW watchdog fires long before the watchdog soft timeout.
At the moment, the watchdog_worker is invoked as a delayed work.
Delayed works are handled by non realtime kernel threads. The
WQ_HIGHPRI flag only increases the niceness of that threads.
This patch replaces the delayed work logic by kthread delayed
work,
and sets the associated kernel task to SCHED_FIFO with the
highest
priority, in order to ensure that the watchdog worker will run
as
soon as possible.
1ff688209e2ed23f699269b9733993e2ce123fd2
Author: Christophe Leroy <christophe.leroy@c-s.fr>
AuthorDate: Thu Jan 18 12:11:21 2018 +0100
Commit: Wim Van Sebroeck <wim@iguana.be>
CommitDate: Sun Jan 21 12:44:59 2018 +0100
Follows: v4.15-rc3 (349)
Precedes: v4.16-rc1 (13993)
watchdog: core: make sure the watchdog_worker is not deferred
commit 4cd13c21b207e ("softirq: Let ksoftirqd do its job") has
the
effect of deferring timer handling in case of high CPU load,
hence
delaying the delayed work allthought the worker is running which
high realtime priority.
As hrtimers are not managed by softirqs, this patch replaces the
delayed work by a plain work and uses an hrtimer to schedule
that work.
If I run the same test or 'chrt 50 hackbench 20 -l 150' or any
task where I change the prio with chrt and that runs long enough,
I get a system reset from the watchdog because it times out. This
only happens if the watchdog is already enabled on boot and
CONFIG_PREEMPT_RT_FULL is set.
Any idea if I'm missing something essential? If I understand it
correctly, the two commits fix the framework and therefore the
dw_wdt driver doesn't need any updates.
Best regards,
Steffen
--
Pengutronix e.K. | Steffen Trumtrar
|
Industrial Linux Solutions |
http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany| Phone:
+49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax:
+49-5121-206917-5555|
next reply other threads:[~2018-09-18 18:53 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-18 13:21 Steffen Trumtrar [this message]
2018-09-18 13:46 ` [BUG] dw_wdt watchdog on linux-rt 4.18.5-rt4 not triggering Guenter Roeck
2018-09-19 6:46 ` Steffen Trumtrar
[not found] ` <20180919194303.GA5033@roeck-us.net>
2018-09-20 20:48 ` Julia Cartwright
2018-09-21 13:34 ` Guenter Roeck
2018-09-21 16:42 ` Julia Cartwright
2018-09-21 20:21 ` Guenter Roeck
2018-09-24 7:24 ` Steffen Trumtrar
2018-09-28 21:03 ` [PATCH 0/2] Fix watchdogd wakeup deferral on RT Julia Cartwright
2018-09-28 21:03 ` [PATCH 1/2] kthread: convert worker lock to raw spinlock Julia Cartwright
2018-10-05 16:46 ` Sebastian Andrzej Siewior
2018-10-05 18:10 ` Andrea Parri
2018-10-09 10:56 ` Sebastian Andrzej Siewior
2018-09-28 21:03 ` [PATCH RT 2/2] watchdog, rt: prevent deferral of watchdogd wakeup Julia Cartwright
2018-09-28 22:38 ` kbuild test robot
2018-09-29 6:38 ` Thomas Gleixner
2018-09-29 22:13 ` Sebastian Andrzej Siewior
2018-09-30 1:41 ` [kbuild-all] " Li, Philip
2018-09-28 23:20 ` kbuild test robot
2018-09-30 14:00 ` Guenter Roeck
2018-10-05 16:52 ` Sebastian Andrzej Siewior
2018-09-20 8:18 ` [BUG] dw_wdt watchdog on linux-rt 4.18.5-rt4 not triggering Tim Sander
2018-09-18 18:14 ` Julia Cartwright
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=73d0tbdjqz.fsf@pengutronix.de \
--to=s.trumtrar@pengutronix.de \
--cc=christophe.leroy@c-s.fr \
--cc=linux-rt-users@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).