Re: [RFC PATCH v2 2/2] serial: imx: Switch to nbcon console

[John Ogness <john.ogness@linutronix.de>]

On 2024-09-13, Esben Haabendal <esben@geanix.com> wrote:
> I have now gone through all usage of above mentioned registers in the
> driver. I found a single missing lock/unlock, but other than that the
> driver seems to be in good shape in this regards.

Great. Please send a separate patch for the missing lock/unlock to
mainline. It should be a mainline problem as well.

> In the _probe() function, the following registers are accessed
> unprotected: ucr1, ucr2, ucr3, uts. But I assume this should be safe,
> as the uart port is not registred yet, and interrupt handlers have not
> been registered.

Sure.

> I will send out a v3 short, hoping we can get this in a shape where we
> can get it merged shortly after the 8250 driver nbcon patches.

Great!

Note that I am currently pushing the 8250 nbcon to mainline. It is in
the review process and there have already been significant changes. It
is all 8250-specific changes, so it probably is not related to your
work. Just letting you know. I will CC you on the next series
submission.

John Ogness