From: John Ogness <john.ogness@linutronix.de>
To: Schspa Shi <schspa@gmail.com>,
pmladek@suse.com, sergey.senozhatsky@gmail.com,
rostedt@goodmis.org
Cc: linux-rt-users@vger.kernel.org, linux-kernel@vger.kernel.org,
bigeasy@linutronix.de, tglx@linutronix.de, schspa@gmail.com
Subject: Re: [PATCH 5.10-rt] printk: fix suppressed message print when reboot/panic
Date: Mon, 21 Mar 2022 10:36:55 +0106 [thread overview]
Message-ID: <87a6dj3b5c.fsf@jogness.linutronix.de> (raw)
In-Reply-To: <20220321053815.71316-1-schspa@gmail.com>
On 2022-03-21, Schspa Shi <schspa@gmail.com> wrote:
> Update printk_seq for suppressed message.
>
> Affects 5.9-rt and 5.10-rt
>
> When message is suppressed, printk_seq should be updated, otherwise
> this message will be printed when reboot. This problem was introduced
> in commit 3edc0c85d154 ("printk: Rebase on top of new ring buffer").
>
> Signed-off-by: Schspa Shi <schspa@gmail.com>
Reviewed-by: John Ogness <john.ogness@linutronix.de>
Nice catch. Thanks.
5.15-rt also has this issue, although the fix is slightly different. For
5.15-rt, writing to con->printk_seq (via latched_seq_write()) requires
the console locked. Would you like to post a patch for 5.15-rt as well,
or would you like me to do it?
5.16 and beyond does not have this issue.
John Ogness
next prev parent reply other threads:[~2022-03-21 9:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-21 5:38 [PATCH 5.10-rt] printk: fix suppressed message print when reboot/panic Schspa Shi
2022-03-21 9:30 ` John Ogness [this message]
2022-03-21 11:57 ` Shi Schspa
2022-07-11 16:31 ` Steven Rostedt
2022-07-11 16:37 ` Steven Rostedt
2022-03-21 9:31 ` Sebastian Andrzej Siewior
2022-07-11 16:05 ` Schspa Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a6dj3b5c.fsf@jogness.linutronix.de \
--to=john.ogness@linutronix.de \
--cc=bigeasy@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=schspa@gmail.com \
--cc=sergey.senozhatsky@gmail.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox