From: John Ogness <john.ogness@linutronix.de>
To: Andrew Halaney <ahalaney@redhat.com>,
Steven Rostedt <rostedt@goodmis.org>
Cc: pmladek@suse.com, senozhatsky@chromium.org, debarbos@redhat.com,
williams@redhat.com, jlelli@redhat.com,
linux-rt-users@vger.kernel.org
Subject: Re: [BUG] printk/nbcon can use RCU illegally prior to CPU online
Date: Fri, 19 Jul 2024 10:01:25 +0206 [thread overview]
Message-ID: <87cyn9lssy.fsf@jogness.linutronix.de> (raw)
In-Reply-To: <436jncgrfxwcizjw5gxw3yar5ybo62zdctout6sti6gamwtnlw@gqrmo5ine6d2>
On 2024-07-18, Andrew Halaney <ahalaney@redhat.com> wrote:
> I'll be honest, I only considered this from a printk() point of view
> so far and pretty much ignored the original splat (as someone else is
> looking at that). Here's the original splat from a centos kernel, I
> have yet to look into it other than "we took an exception prior to RCU
> coming online for this CPU"
Thanks for posting the splat. This is indeed a printk()
issue. vprintk_emit() or nbcon_wake_threads() need to be aware of the
RCU state and act appropriately. I will look into this.
> and me naively thinking that printk() should work everywhere.
Your thinking is not naive. It is correct (for PREEMPT_RT). printk()
stores messages locklessly into its ringbuffer and must work in all
cases (including NMI and scheduler). And AFAIK it does.
However, printk() is also responsible for reliably triggering or
performing console printing. This separate responsibility is tricky. For
PREEMPT_RT the problem is supposed to be solved. Obviously it still has
some issues, so thank you for the report.
For PREEMPT_RT, if you can put a printk() anywhere after the Linux
banner and cause a problem, the printk-folks need to know about it.
John Ogness
next prev parent reply other threads:[~2024-07-19 7:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-18 15:41 [BUG] printk/nbcon can use RCU illegally prior to CPU online Andrew Halaney
2024-07-18 15:57 ` Steven Rostedt
2024-07-18 18:13 ` Andrew Halaney
2024-07-18 19:24 ` Steven Rostedt
2024-07-18 19:34 ` Andrew Halaney
2024-07-18 20:17 ` Steven Rostedt
2024-07-19 7:55 ` John Ogness [this message]
2024-07-19 14:09 ` Andrew Halaney
2024-07-19 14:55 ` John Ogness
2024-07-19 15:02 ` Andrew Halaney
2024-07-19 8:26 ` John Ogness
2024-07-19 16:01 ` Andrew Halaney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87cyn9lssy.fsf@jogness.linutronix.de \
--to=john.ogness@linutronix.de \
--cc=ahalaney@redhat.com \
--cc=debarbos@redhat.com \
--cc=jlelli@redhat.com \
--cc=linux-rt-users@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox