Re: [PATCH 4/5] rteval: hackbench.py: Enable running on a system with low memory

Punit Agrawal
2021-09-15T01:55:00Z

John Kacur <jkacur@redhat.com> writes:

> On Wed, 1 Sep 2021, Punit Agrawal wrote:
>
>> From: Punit Agrawal <punit1.agrawal@toshiba.co.jp>
>>
>> The hackbench workload refues to run on RockPro64, a hexacore 64bit
>> Arm board with 4GB memory, complaining about insufficient memory
>> per-core.
>>
>> On further investigation, it turns out that workload is using an
>> arbitrary limit of 0.75 GB/core but will quite happily run on much
>> lower lower memory systems.
>>
>> Instead of preventing execution, convert the info message to a warning
>> when the memory is lower than expected but continue execution. This
>> should enable the workload to be used on a wider range of systems.
>>
>> Signed-off-by: Punit Agrawal <punit1.agrawal@toshiba.co.jp>
>> ---
>> rteval/modules/loads/hackbench.py | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/rteval/modules/loads/hackbench.py b/rteval/modules/loads/hackbench.py
>> index 3b692070e9d9..ab028c495d8b 100644
>> --- a/rteval/modules/loads/hackbench.py
>> +++ b/rteval/modules/loads/hackbench.py
>> @@ -55,9 +55,8 @@ class Hackbench(CommandLineLoad):
>> if ratio >= 0.75:
>> mult = float(self._cfg.setdefault('jobspercore', 2))
>> else:
>> - self._log(Log.INFO, "Low memory system (%f GB/core)! Not running" % ratio)
>> + self._log(Log.WARN, "Low memory system (%f GB/core)!" % ratio)
>> mult = 0
>> - self._donotrun = True
>>
>> sysTop = SysTopology()
>> # get the number of nodes
>> --
>> 2.32.0
>>
>>
> Signed-off-by: John Kacur <jkacur@redhat.com>

Thanks for applying the patches - both from here and the misc-fixes. I
will address the comments on the cyclictest set and resend them.