Re: [RFC 7/7] rt-tests: cyclictest: Add support to report standard deviation

[Punit Agrawal <punitagrawal@gmail.com>]

Daniel Wagner <wagi@monom.org> writes:

> Hi Punit,
>
> On Thu, Oct 14, 2021 at 04:12:47PM +0900, Punit Agrawal wrote:
>> @@ -1781,6 +1810,7 @@ static void write_stats(FILE *f, void *data)
>>  		fprintf(f, "      \"min\": %ld,\n", s->min);
>>  		fprintf(f, "      \"max\": %ld,\n", s->max);
>>  		fprintf(f, "      \"avg\": %.2f,\n", s->avg);
>> +		fprintf(f, "      \"stddev\": %.2f,\n", calc_stddev(s));
>>  		fprintf(f, "      \"cpu\": %d,\n", par[i]->cpu);
>>  		fprintf(f, "      \"node\": %d\n", par[i]->node);
>>  		fprintf(f, "    }%s\n", i == num_threads - 1 ? "" : ",");
>
> I think in this case you should also increase the version number of the
> JSON file.

Sure, I can bump up the version to 1.1 - minor update as it's adding a
new field rather than changing existing ones. Or "2" if that is
preferred.

Taking a closer look, the rt_write_json() helper, that outputs the
version, is shared with other tools. Bumping the version will bump it up
for all of them - would that be OK?

> And while at it, I'd love to see the same stats
> fixes/extension for the other tools, not just cyclictest.

I can look at adding support for standard deviation to the other tools
if there's interest once the cyclictest changes have been merged.

Thanks for taking a look.

Punit