public inbox for linux-rt-users@vger.kernel.org
 help / color / mirror / Atom feed
From: John Ogness <john.ogness@linutronix.de>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	Mike Galbraith <efault@gmx.de>
Cc: RT <linux-rt-users@vger.kernel.org>
Subject: Re: v5.19-rc2-rt3: nouveau might sleep splat
Date: Fri, 24 Jun 2022 16:36:07 +0206	[thread overview]
Message-ID: <87wnd616ds.fsf@jogness.linutronix.de> (raw)
In-Reply-To: <YrWPiwtk0kAWxXI9@linutronix.de>

On 2022-06-24, Sebastian Andrzej Siewior <bigeasy@linutronix.de> wrote:
>> (gdb) list *vprintk_store+0x3cc
>> 0xffffffff8114283c is in vprintk_store (kernel/printk/printk.c:2280).
>> warning: Source file is more recent than executable.
>> 2275            u32 caller_id;
>> 2276            u16 text_len;
>> 2277            int ret = 0;
>> 2278            u64 ts_nsec;
>> 2279
>> 2280            if (!printk_enter_irqsave(recursion_ptr, irqflags))
>> 2281                    return 0;
>> 2282
>> 2283            /*
>> 2284             * Since the duration of printk() can vary depending on the message
>> (gdb)
>
> Why do we need to keep interrupts disabled for vsnprintf()?

vsnprintf is printing the current CPU local clock and the current CPU
ID. Are you recommending we split printk_enter_irqsave() into various
preempt_disable() and local_irq_save() calls?

As to this the actual problem reported in this thread, I believe this
patch solves it:

https://lore.kernel.org/lkml/20220609121709.12939-1-Jason@zx2c4.com

John Ogness

  parent reply	other threads:[~2022-06-24 14:30 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-18  9:25 v5.19-rc2-rt3: nouveau might sleep splat Mike Galbraith
2022-06-24  8:42 ` Sebastian Andrzej Siewior
2022-06-24  9:52   ` Mike Galbraith
2022-06-24 10:18     ` Sebastian Andrzej Siewior
2022-06-24 10:19       ` Sebastian Andrzej Siewior
2022-06-24 14:30       ` John Ogness [this message]
2022-06-24 14:31         ` John Ogness
2022-06-24 14:39           ` Sebastian Andrzej Siewior
2022-06-25  3:26             ` Mike Galbraith
2022-07-21 13:06           ` Mike Galbraith
2022-07-25  8:15             ` Sebastian Andrzej Siewior
2022-07-25  9:58               ` John Ogness
2022-07-25 13:26                 ` Mike Galbraith
2022-08-03 16:10                 ` Petr Mladek
2022-08-05 14:23                   ` John Ogness

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wnd616ds.fsf@jogness.linutronix.de \
    --to=john.ogness@linutronix.de \
    --cc=bigeasy@linutronix.de \
    --cc=efault@gmx.de \
    --cc=linux-rt-users@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox