* [PATCH RESEND v2] cyclictest: Fixed incorrect wakeup reset interface
@ 2011-03-09 15:08 Geunsik Lim
2011-03-09 15:30 ` Carsten Emde
0 siblings, 1 reply; 5+ messages in thread
From: Geunsik Lim @ 2011-03-09 15:08 UTC (permalink / raw)
To: williams, Carsten Emde; +Cc: jkacur, linux-rt-users, tglx
When we try to run ftrace with cyclictest command of rt-test,
We view the error according to base kernel version.
We need to modify this hard coded interface.
Signed-off-by: Geunsik Lim <geunsik.lim@samsung.com>
Reviewed-by: Carsten Emde <C.Emde@osadl.org>
---
src/cyclictest/cyclictest.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/src/cyclictest/cyclictest.c b/src/cyclictest/cyclictest.c
index 0847aed..abc0b4e 100644
--- a/src/cyclictest/cyclictest.c
+++ b/src/cyclictest/cyclictest.c
@@ -487,7 +487,7 @@ static void setup_tracer(void)
setkernvar(traceroptions, traceptr[i]);
}
setkernvar("tracing_max_latency", "0");
- setkernvar("latency_hist/wakeup_latency/reset", "1");
+ setkernvar("latency_hist/wakeup/reset", "1");
} else {
setkernvar("trace_all_cpus", "1");
setkernvar("trace_freerunning", "1");
--
1.7.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH RESEND v2] cyclictest: Fixed incorrect wakeup reset interface
2011-03-09 15:08 [PATCH RESEND v2] cyclictest: Fixed incorrect wakeup reset interface Geunsik Lim
@ 2011-03-09 15:30 ` Carsten Emde
2011-03-09 20:26 ` John Kacur
2011-03-09 20:27 ` John Kacur
0 siblings, 2 replies; 5+ messages in thread
From: Carsten Emde @ 2011-03-09 15:30 UTC (permalink / raw)
To: Geunsik Lim; +Cc: williams, jkacur, linux-rt-users, tglx
On 03/09/2011 04:08 PM, Geunsik Lim wrote:
> When we try to run ftrace with cyclictest command of rt-test,
> We view the error according to base kernel version.
> We need to modify this hard coded interface.
>
> Signed-off-by: Geunsik Lim<geunsik.lim@samsung.com>
We need a space here: Geunsik Lim <geunsik.lim@samsung.com>
> ---
> src/cyclictest/cyclictest.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
Oops, this is still old, it's only 1 insertion now. You could have
produced a real patch, couldn't you?
> diff --git a/src/cyclictest/cyclictest.c b/src/cyclictest/cyclictest.c
> index 0847aed..abc0b4e 100644
> --- a/src/cyclictest/cyclictest.c
> +++ b/src/cyclictest/cyclictest.c
> @@ -487,7 +487,7 @@ static void setup_tracer(void)
> setkernvar(traceroptions, traceptr[i]);
> }
> setkernvar("tracing_max_latency", "0");
> - setkernvar("latency_hist/wakeup_latency/reset", "1");
> + setkernvar("latency_hist/wakeup/reset", "1");
> } else {
> setkernvar("trace_all_cpus", "1");
> setkernvar("trace_freerunning", "1");
Acked-by: Carsten Emde <C.Emde@osadl.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH RESEND v2] cyclictest: Fixed incorrect wakeup reset interface
2011-03-09 15:30 ` Carsten Emde
@ 2011-03-09 20:26 ` John Kacur
2011-03-09 23:32 ` Geunsik Lim
2011-03-09 20:27 ` John Kacur
1 sibling, 1 reply; 5+ messages in thread
From: John Kacur @ 2011-03-09 20:26 UTC (permalink / raw)
To: Carsten Emde; +Cc: Geunsik Lim, williams, linux-rt-users, tglx
[-- Attachment #1: Type: text/plain, Size: 1420 bytes --]
On Wed, Mar 9, 2011 at 4:30 PM, Carsten Emde <C.Emde@osadl.org> wrote:
> On 03/09/2011 04:08 PM, Geunsik Lim wrote:
>
>> When we try to run ftrace with cyclictest command of rt-test,
>> We view the error according to base kernel version.
>> We need to modify this hard coded interface.
>>
>> Signed-off-by: Geunsik Lim<geunsik.lim@samsung.com>
>>
> We need a space here: Geunsik Lim <geunsik.lim@samsung.com>
>
>
> ---
>> src/cyclictest/cyclictest.c | 3 ++-
>> 1 files changed, 2 insertions(+), 1 deletions(-)
>>
> Oops, this is still old, it's only 1 insertion now. You could have produced
> a real patch, couldn't you?
>
>
> diff --git a/src/cyclictest/cyclictest.c b/src/cyclictest/cyclictest.c
>> index 0847aed..abc0b4e 100644
>> --- a/src/cyclictest/cyclictest.c
>> +++ b/src/cyclictest/cyclictest.c
>> @@ -487,7 +487,7 @@ static void setup_tracer(void)
>> setkernvar(traceroptions, traceptr[i]);
>> }
>> setkernvar("tracing_max_latency", "0");
>> - setkernvar("latency_hist/wakeup_latency/reset", "1");
>> + setkernvar("latency_hist/wakeup/reset", "1");
>> } else {
>> setkernvar("trace_all_cpus", "1");
>> setkernvar("trace_freerunning", "1");
>>
> Acked-by: Carsten Emde <C.Emde@osadl.org>
>
>
Did it used to be wakeup_latency in an older version that we still need to
support?
[-- Attachment #2: Type: text/html, Size: 2593 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH RESEND v2] cyclictest: Fixed incorrect wakeup reset interface
2011-03-09 15:30 ` Carsten Emde
2011-03-09 20:26 ` John Kacur
@ 2011-03-09 20:27 ` John Kacur
1 sibling, 0 replies; 5+ messages in thread
From: John Kacur @ 2011-03-09 20:27 UTC (permalink / raw)
To: Carsten Emde; +Cc: Geunsik Lim, williams, linux-rt-users, tglx
On Wed, Mar 9, 2011 at 4:30 PM, Carsten Emde <C.Emde@osadl.org> wrote:
>
> On 03/09/2011 04:08 PM, Geunsik Lim wrote:
>>
>> When we try to run ftrace with cyclictest command of rt-test,
>> We view the error according to base kernel version.
>> We need to modify this hard coded interface.
>>
>> Signed-off-by: Geunsik Lim<geunsik.lim@samsung.com>
>
> We need a space here: Geunsik Lim <geunsik.lim@samsung.com>
>
>> ---
>> src/cyclictest/cyclictest.c | 3 ++-
>> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> Oops, this is still old, it's only 1 insertion now. You could have produced a real patch, couldn't you?
>
>> diff --git a/src/cyclictest/cyclictest.c b/src/cyclictest/cyclictest.c
>> index 0847aed..abc0b4e 100644
>> --- a/src/cyclictest/cyclictest.c
>> +++ b/src/cyclictest/cyclictest.c
>> @@ -487,7 +487,7 @@ static void setup_tracer(void)
>> setkernvar(traceroptions, traceptr[i]);
>> }
>> setkernvar("tracing_max_latency", "0");
>> - setkernvar("latency_hist/wakeup_latency/reset", "1");
>> + setkernvar("latency_hist/wakeup/reset", "1");
>> } else {
>> setkernvar("trace_all_cpus", "1");
>> setkernvar("trace_freerunning", "1");
>
> Acked-by: Carsten Emde <C.Emde@osadl.org>
Did it used to be wakeup_latency in an older version that we still need to
support?
--
To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH RESEND v2] cyclictest: Fixed incorrect wakeup reset interface
2011-03-09 20:26 ` John Kacur
@ 2011-03-09 23:32 ` Geunsik Lim
0 siblings, 0 replies; 5+ messages in thread
From: Geunsik Lim @ 2011-03-09 23:32 UTC (permalink / raw)
To: John Kacur; +Cc: Carsten Emde, williams, linux-rt-users, tglx
On Thu, Mar 10, 2011 at 5:26 AM, John Kacur <jkacur@redhat.com> wrote:
>
>
> On Wed, Mar 9, 2011 at 4:30 PM, Carsten Emde <C.Emde@osadl.org> wrote:
>>
>> On 03/09/2011 04:08 PM, Geunsik Lim wrote:
>>>
>>> When we try to run ftrace with cyclictest command of rt-test,
>>> We view the error according to base kernel version.
>>> We need to modify this hard coded interface.
>>>
>>> Signed-off-by: Geunsik Lim<geunsik.lim@samsung.com>
>>
>> We need a space here: Geunsik Lim <geunsik.lim@samsung.com>
>>
>>> ---
>>> src/cyclictest/cyclictest.c | 3 ++-
>>> 1 files changed, 2 insertions(+), 1 deletions(-)
>>
>> Oops, this is still old, it's only 1 insertion now. You could have
>> produced a real patch, couldn't you?
>>
>>> diff --git a/src/cyclictest/cyclictest.c b/src/cyclictest/cyclictest.c
>>> index 0847aed..abc0b4e 100644
>>> --- a/src/cyclictest/cyclictest.c
>>> +++ b/src/cyclictest/cyclictest.c
>>> @@ -487,7 +487,7 @@ static void setup_tracer(void)
>>> setkernvar(traceroptions, traceptr[i]);
>>> }
>>> setkernvar("tracing_max_latency", "0");
>>> - setkernvar("latency_hist/wakeup_latency/reset", "1");
>>> + setkernvar("latency_hist/wakeup/reset", "1");
>>> } else {
>>> setkernvar("trace_all_cpus", "1");
>>> setkernvar("trace_freerunning", "1");
>>
>> Acked-by: Carsten Emde <C.Emde@osadl.org>
>
> Did it used to be wakeup_latency in an older version that we still need to
> support?
At first, I sent patch file to support both old version(e.g: 2.6.24
and current version(e.g: 2.6.33)
And then, I resent this patch file after update according to the
review of Carsten Emde.
> This is not correct - probably an unintended insertion of the line that was removed abov
At that time, I think that We,may support latest Linux version. So, I
agreed with
Carsten's review. But, I understood incorrectly the reply of Carsten Emde about
my initial patch content.
Belows is wakeup interface per each Linus version. I summarized to understand
the goal of original patch file.
2.6.24.7-rt23 /sys/kernel/debug/tracing/latency_hist/wakeup_latency/reset
2.6.31-rc9-rt9.1 /sys/kernel/debug/tracing/latency_hist/wakeup/reset
2.6.33.7.2-rt30 /sys/kernel/debug/tracing/latency_hist/wakeup/reset
John. You are right. In my case, I am using RHEL5-MRG(2.6.24) and
RHEL6(2.6.32).
We have to support for software compatibility both previous Linux version
and current Linux version.
John, Please, apply the previous original patch.
Or If Carsten Emde agree with this explanation for consensus,
I will resend the original patch including additional reviewers like
John , Carsten
file.
--
Regards,
Geunsik Lim ( Samsung Electronics )
Blog : http://blog.naver.com/invain/
e-Mail: geunsik.lim@samsung.com
leemgs@gmail.com , leemgs1@gmail.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-03-09 23:32 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-09 15:08 [PATCH RESEND v2] cyclictest: Fixed incorrect wakeup reset interface Geunsik Lim
2011-03-09 15:30 ` Carsten Emde
2011-03-09 20:26 ` John Kacur
2011-03-09 23:32 ` Geunsik Lim
2011-03-09 20:27 ` John Kacur
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).