Re: [PATCH V4 3/4] block: queue work on unbound wq

[Viresh Kumar <viresh.kumar@linaro.org>]

On 9 April 2013 14:48, Amit Kucheria <amit.kucheria@linaro.org> wrote:
> On Tue, Apr 9, 2013 at 1:00 PM, Viresh Kumar <viresh.kumar@linaro.org> wrote:

>> diff --git a/kernel/power/Kconfig b/kernel/power/Kconfig
>> +config WQ_POWER_EFFICIENT
>> +       bool "Workqueue allocated as UNBOUND for power efficiency"
>> +       depends on PM
>
> Should default to N so that existing configs don't get prompted for a choice.

I thought defaults default is N if not present. I can add default n if
it is required.

>> diff --git a/kernel/workqueue.c b/kernel/workqueue.c
>> +static bool wq_power_efficient = 0;
>
> 1?

It should be disabled by default even if CONFIG_WQ_POWER_EFFICIENT is
selected and so initialized it with zero.. Though i don't need to
initialize it as
default is 0.