From: Peter LaDow <petela@gocougs.wsu.edu>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org,
linux-rt-users <linux-rt-users@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Carsten Emde <C.Emde@osadl.org>, John Kacur <jkacur@redhat.com>
Subject: Re: [PATCH RT 3/4] net: netfilter: Serialize xt_write_recseq sections on RT
Date: Thu, 1 Nov 2012 17:36:25 -0700 [thread overview]
Message-ID: <CAN8Q1EcHJyDMs-z8Vw_=cpnCL2FO_pATaGThh2UHv4ketC-_Jw@mail.gmail.com> (raw)
In-Reply-To: <20121031003314.763160265@goodmis.org>
On Tue, Oct 30, 2012 at 5:33 PM, Steven Rostedt <rostedt@goodmis.org> wrote:
> From: Thomas Gleixner <tglx@linutronix.de>
>
> The netfilter code relies only on the implicit semantics of
> local_bh_disable() for serializing wt_write_recseq sections. RT breaks
> that and needs explicit serialization here.
>
> Reported-by: Peter LaDow <petela@gocougs.wsu.edu>
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> diff --git a/include/linux/locallock.h b/include/linux/locallock.h
> index f1804a3..a5eea5d 100644
> diff --git a/include/linux/netfilter/x_tables.h b/include/linux/netfilter/x_tables.h
> index 32cddf7..bed90da2 100644
> diff --git a/net/netfilter/core.c b/net/netfilter/core.c
> index 899b71c..5db16ea 100644
I'm have a setup running 3.0.48-rt72. It's been running about 8 hours
so far, and tomorrow I'll know if there's been any problems. I'm
confident things will be fine tomorrow, and at that time I'll be glad
to attach a Tested-by tag.
Thanks,
Pete
next prev parent reply other threads:[~2012-11-02 0:36 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-31 0:32 [PATCH RT 0/4] [ANNOUNCE] 3.0.48-rt72-rc1 stable review Steven Rostedt
2012-10-31 0:32 ` [PATCH RT 1/4] hrtimer: Raise softirq if hrtimer irq stalled Steven Rostedt
2012-10-31 0:33 ` [PATCH RT 2/4] rcu: Disable RCU_FAST_NO_HZ on RT Steven Rostedt
2012-10-31 0:33 ` [PATCH RT 3/4] net: netfilter: Serialize xt_write_recseq sections " Steven Rostedt
2012-10-31 18:25 ` Peter LaDow
2012-11-01 21:26 ` Thomas Gleixner
2012-11-01 22:30 ` Peter LaDow
2012-11-01 22:58 ` Steven Rostedt
2012-11-01 23:01 ` Thomas Gleixner
2012-11-02 0:40 ` Peter LaDow
2012-11-02 0:36 ` Peter LaDow [this message]
2012-11-02 22:25 ` Peter LaDow
2012-11-02 22:28 ` Peter LaDow
2012-10-31 0:33 ` [PATCH RT 4/4] Linux 3.0.48-rt72-rc1 Steven Rostedt
-- strict thread matches above, loose matches on Subject: below --
2012-10-31 0:31 [PATCH RT 0/4] [ANNOUNCE] 3.2.32-rt49-rc1 stable review Steven Rostedt
2012-10-31 0:31 ` [PATCH RT 3/4] net: netfilter: Serialize xt_write_recseq sections on RT Steven Rostedt
2012-10-31 0:29 [PATCH RT 0/4] [ANNOUNCE] 3.4.15-rt26-rc1 stable review Steven Rostedt
2012-10-31 0:29 ` [PATCH RT 3/4] net: netfilter: Serialize xt_write_recseq sections on RT Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAN8Q1EcHJyDMs-z8Vw_=cpnCL2FO_pATaGThh2UHv4ketC-_Jw@mail.gmail.com' \
--to=petela@gocougs.wsu.edu \
--cc=C.Emde@osadl.org \
--cc=jkacur@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).