From: Remy Bohmer <linux@bohmer.net>
To: Darren Hart <dvhart@linux.intel.com>
Cc: linux-rt-users@vger.kernel.org,
Clark Williams <williams@redhat.com>,
John Kacur <jkacur@redhat.com>,
Denys Dmytriyenko <denis@denix.org>
Subject: Re: [PATCH 1/3] rt-tests: Support user supplied CFLAGS and LDFLAGS
Date: Tue, 20 Mar 2012 20:31:58 +0100 [thread overview]
Message-ID: <CANqCtQK+egf9i=Qb5r9zSt1Ahm4zTpFW3dHsMnn68DsT2YuDXg@mail.gmail.com> (raw)
In-Reply-To: <3343440fb02872debc8b49be5261aec530a205f3.1332270303.git.dvhart@linux.intel.com>
Hi,
2012/3/20 Darren Hart <dvhart@linux.intel.com>:
> Accept user supplied CFLAGS and LDFLAGS, overwriting the
> Makefile supplied versions. This can cause the build to
> fail if the user does not provide at least what the Makefile
> defines, but so be it.
> -CFLAGS = -D_GNU_SOURCE -Wall -Wno-nonnull -Isrc/include
> +CFLAGS ?= -D_GNU_SOURCE -Wall -Wno-nonnull -Isrc/include
> +LDFLAGS ?=
Why not append the Makefile local flags to the user supplied flags?
Something like:
CFLAGS := $(CFLAGS) -D_GNU_SOURCE -Wall -Wno-nonnull -Isrc/include
Kind regards,
Remy
next prev parent reply other threads:[~2012-03-20 19:31 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-20 19:05 [PATCH 1/3] rt-tests: Support user supplied CFLAGS and LDFLAGS Darren Hart
2012-03-20 19:05 ` [PATCH 2/3] rt-tests: Silence unused-but-set warning in rt-migrate-test Darren Hart
2012-03-21 14:05 ` Steven Rostedt
2012-03-21 14:44 ` Darren Hart
2012-03-21 14:56 ` John Kacur
2012-03-21 16:18 ` Steven Rostedt
2012-03-21 16:36 ` Darren Hart
2012-03-21 16:41 ` John Kacur
2012-03-21 16:45 ` Darren Hart
2012-03-21 16:51 ` Steven Rostedt
2012-03-21 16:45 ` Steven Rostedt
2012-03-21 17:11 ` Steven Rostedt
2012-03-21 17:46 ` John Kacur
2012-03-20 19:05 ` [PATCH 3/3] rt-tests: Remove unused status variable Darren Hart
2012-03-21 13:35 ` John Kacur
2012-03-21 14:45 ` Darren Hart
2012-03-20 19:31 ` Remy Bohmer [this message]
2012-03-20 19:45 ` [PATCH 1/3] rt-tests: Support user supplied CFLAGS and LDFLAGS Darren Hart
2012-03-20 19:57 ` Remy Bohmer
2012-03-20 23:58 ` John Kacur
2012-03-21 0:10 ` Darren Hart
2012-03-21 19:10 ` Denys Dmytriyenko
2012-03-21 19:11 ` Darren Hart
2012-03-21 20:16 ` John Kacur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANqCtQK+egf9i=Qb5r9zSt1Ahm4zTpFW3dHsMnn68DsT2YuDXg@mail.gmail.com' \
--to=linux@bohmer.net \
--cc=denis@denix.org \
--cc=dvhart@linux.intel.com \
--cc=jkacur@redhat.com \
--cc=linux-rt-users@vger.kernel.org \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).