From: John Kacur <jkacur@redhat.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Thomas Schauss <schauss@tum.de>,
Thomas Gleixner <tglx@linutronix.de>,
RT <linux-rt-users@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>
Subject: Re: 3.2-rc1 and nvidia drivers
Date: Wed, 30 Nov 2011 14:39:55 +0100 [thread overview]
Message-ID: <CAONaPpH5QgZ4peSWACmyT-6JRsd+e3Moip9Fu4v2kuTknP40Ow@mail.gmail.com> (raw)
In-Reply-To: <1322660085.17003.112.camel@frodo>
On Wed, Nov 30, 2011 at 2:34 PM, Steven Rostedt <rostedt@goodmis.org> wrote:
> On Wed, 2011-11-30 at 09:23 +0100, John Kacur wrote:
>
>> Steve - I'm aware that this is a false positive, I discussed this with
>> Peter already. Normally I don't like the idea of changing code for a
>> tool, but if you see the comment that they wrote above where I put the
>> unlock - it was an extraordinary thing NOT to drop the lock here, as
>> slab_destroy is normally called without it. It doesn't seem like good
>> form to me to hold a lock longer than you need it, and it is a simple
>> solution to getting rid of the lockdep splat. (false positive, or
>> false negative, depending on how you see it.) That being said, I'm not
>> adverse to another solution either, but this one should work and is
>> simple.
>
> This is a mainline issue, and it should go there. If mainline accepts
> it, then fine. Otherwise, it's not going to go into -rt.
>
Quoting myself "Could you try the following patch to see if it gets
rid of your lockdep
splat? (plan to neaten it up and send it to lkml if it works for you.)"
I never requested this go into -rt directly.
John
next prev parent reply other threads:[~2011-11-30 13:39 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-16 9:10 3.2-rc1 and nvidia drivers Javier Sanz
2011-11-16 9:40 ` Thomas Schauss
2011-11-16 15:06 ` Thomas Gleixner
2011-11-28 10:08 ` Thomas Schauss
2011-11-28 11:31 ` John Kacur
2011-11-29 14:31 ` John Kacur
2011-11-30 2:36 ` Steven Rostedt
2011-11-30 8:23 ` John Kacur
2011-11-30 11:14 ` Peter Zijlstra
2011-11-30 14:14 ` Steven Rostedt
2011-11-30 14:16 ` Peter Zijlstra
2011-11-30 14:28 ` Steven Rostedt
2011-11-30 14:31 ` Steven Rostedt
2011-11-30 14:34 ` Peter Zijlstra
2011-11-30 15:07 ` Thomas Schauss
2011-11-30 15:20 ` Steven Rostedt
2011-12-02 17:41 ` Thomas Schauss
2011-12-02 19:37 ` Steven Rostedt
2011-11-30 13:34 ` Steven Rostedt
2011-11-30 13:39 ` John Kacur [this message]
2011-11-30 13:49 ` Steven Rostedt
2011-11-30 13:53 ` John Kacur
2011-11-30 9:06 ` Thomas Schauss
2011-11-16 9:52 ` Mike Galbraith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAONaPpH5QgZ4peSWACmyT-6JRsd+e3Moip9Fu4v2kuTknP40Ow@mail.gmail.com \
--to=jkacur@redhat.com \
--cc=linux-rt-users@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=schauss@tum.de \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).