From: Peter Xu <peterx@redhat.com>
To: Nicolas Saenz Julienne <nsaenzju@redhat.com>
Cc: linux-rt-users@vger.kernel.org, williams@redhat.com, jkacur@redhat.com
Subject: Re: [PATCH 2/2] oslat: Add trace maker prior starting main thread
Date: Fri, 9 Jul 2021 14:39:54 -0400 [thread overview]
Message-ID: <YOiX+lp/PQL136TZ@t490s> (raw)
In-Reply-To: <20210709155414.610308-2-nsaenzju@redhat.com>
On Fri, Jul 09, 2021 at 05:54:14PM +0200, Nicolas Saenz Julienne wrote:
> After a long tracing session it's sometimes hard to find the moment
> oslat started. So leave a message in the trace buffer just before the
> main thread starts.
>
> Signed-off-by: Nicolas Saenz Julienne <nsaenzju@redhat.com>
> ---
> src/oslat/oslat.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/src/oslat/oslat.c b/src/oslat/oslat.c
> index d35be57..20bf02b 100644
> --- a/src/oslat/oslat.c
> +++ b/src/oslat/oslat.c
> @@ -400,6 +400,10 @@ static void *thread_main(void *arg)
> while (g.n_threads_running != g.n_threads)
> relax();
>
> + if (!g.preheat)
> + tracemark(false, "%s: Starting thread on CPU %d.\n",
> + g.app_name, t->core_i);
> +
> frc(&t->frc_start);
> doit(t);
> frc(&t->frc_stop);
> --
> 2.31.1
>
Not sure how it would help.. but no objection either. :)
Acked-by: Peter Xu <peterx@redhat.com>
--
Peter Xu
next prev parent reply other threads:[~2021-07-09 18:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-09 15:54 [PATCH 1/2] rt-utils: Add option to avoid stopping tracing in tracemark() Nicolas Saenz Julienne
2021-07-09 15:54 ` [PATCH 2/2] oslat: Add trace maker prior starting main thread Nicolas Saenz Julienne
2021-07-09 18:39 ` Peter Xu [this message]
2021-07-12 10:17 ` nicolassaenzj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YOiX+lp/PQL136TZ@t490s \
--to=peterx@redhat.com \
--cc=jkacur@redhat.com \
--cc=linux-rt-users@vger.kernel.org \
--cc=nsaenzju@redhat.com \
--cc=williams@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox