From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Ingo Molnar <mingo@redhat.com>, Shuah Khan <shuah@kernel.org>,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-rt-users@vger.kernel.org, joseph.salisbury@canonical.com,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH v3] selftests/ftrace: Do not trace do_softirq because of PREEMPT_RT
Date: Mon, 14 Feb 2022 12:19:02 +0100 [thread overview]
Message-ID: <Ygo6pqWmkTWJNNcR@linutronix.de> (raw)
In-Reply-To: <20220214083657.165921-1-krzysztof.kozlowski@canonical.com>
On 2022-02-14 09:36:57 [+0100], Krzysztof Kozlowski wrote:
> The PREEMPT_RT patchset does not use do_softirq() function thus trying
> to filter for do_softirq fails for such kernel:
>
> echo do_softirq
> ftracetest: 81: echo: echo: I/O error
>
> Choose some other visible function for the test. The function does not
> have to be actually executed during the test, because it is only testing
> filter API interface.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> Reviewed-by: Shuah Khan <skhan@linuxfoundation.org>
> Reviewed-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Acked-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> Notes:
> I understand that the failure does not exist on mainline kernel (only
> with PREEMPT_RT patchset) but the change does not harm it.
Yes, and now it does not sound (to me) like duct tape. Thank you.
> If it is not suitable alone, please consider it for RT patchset.
We trying to get it merged so…
Sebastian
next prev parent reply other threads:[~2022-02-14 11:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-14 8:36 [PATCH v3] selftests/ftrace: Do not trace do_softirq because of PREEMPT_RT Krzysztof Kozlowski
2022-02-14 11:19 ` Sebastian Andrzej Siewior [this message]
2022-02-14 18:33 ` Shuah Khan
2022-02-14 18:39 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ygo6pqWmkTWJNNcR@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=joseph.salisbury@canonical.com \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=shuah@kernel.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox