From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C78FC43334 for ; Fri, 15 Jul 2022 07:47:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232235AbiGOHrX (ORCPT ); Fri, 15 Jul 2022 03:47:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46450 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232224AbiGOHrT (ORCPT ); Fri, 15 Jul 2022 03:47:19 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 662167CB40 for ; Fri, 15 Jul 2022 00:47:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1657871232; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RvUIvaAb68ta9xs2cebppc30SHEKCMbivCeyU2f0Fdg=; b=JF9nAMMqQTdWq9ItBwXc8hEVBoEXRepOuOP5DoZRJsM7y4+aJwQhmbDWXB3vGVQezjgA18 bBsMH5lgWaSCJHxW+ClF+r3GhTYBdqOtxmWw1h26eGGSwk1oAlJrx0WqEkdoE2WHWrsmUu yltjs0AEUmtvKr4RES/CI1wqJjeED74= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-385-s6BcJHNsNSegtvUI7uK2TA-1; Fri, 15 Jul 2022 03:47:11 -0400 X-MC-Unique: s6BcJHNsNSegtvUI7uK2TA-1 Received: by mail-wr1-f71.google.com with SMTP id i9-20020adfa509000000b0021d865ce5e3so962396wrb.6 for ; Fri, 15 Jul 2022 00:47:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=RvUIvaAb68ta9xs2cebppc30SHEKCMbivCeyU2f0Fdg=; b=e66XNnNgvdU+wZHxN+ZOS+52CHzOjmpfkO9EV0Du3EWzRO/l8+2RsYq8ZpDgN2no0G FmTvhsiUy9XCZJGL+1Xn3N67kpWtacCv7gTLsFk6rpYQwDrL8K3gDu4YZC0+LWcgqTKy cmcP6LVhYtUUx8P7XnU1/AjWJxDi10ZGYgzIwn8z9xki9R2OY6vrBoeBXW2+TlQIpJH3 PVZmGtQ8l3mxesqb+fVwUE5tw/eIIF743XGlkpPnQzgcI7K2/m7etmUgLrYXQ9PVjLL1 xCkdF5SXZjTeJBMkfRV/PiuPJ3YeHoXOc/ybS3xSjE8Sa3yvaaMW0XO23q/tR0T09+8G KrRA== X-Gm-Message-State: AJIora/mdacNwCDN4jTMmnnjPLrclV255zzBTymoEiLzp73sa5iRRkBQ CS9KbsHo1c/j2kvL4SqLstl05Synwzwmcz61TLks2+QNW0ZhuJM9P0LMMtrec/UpCUnWSjxsdUL 85S0pXFz6JSX9fsUif4M994NWRPU= X-Received: by 2002:a05:600c:ce:b0:3a2:e02b:bd8e with SMTP id u14-20020a05600c00ce00b003a2e02bbd8emr18753993wmm.123.1657871226933; Fri, 15 Jul 2022 00:47:06 -0700 (PDT) X-Google-Smtp-Source: AGRyM1sWi6WDtLC4iRG0UKo6+d6zAXgsOzpYyYaohC57Jn2ZI7lsJknnQyPLMW5GQFvH5BH6xzUhMw== X-Received: by 2002:a05:600c:ce:b0:3a2:e02b:bd8e with SMTP id u14-20020a05600c00ce00b003a2e02bbd8emr18753964wmm.123.1657871226663; Fri, 15 Jul 2022 00:47:06 -0700 (PDT) Received: from localhost.localdomain ([151.29.55.241]) by smtp.gmail.com with ESMTPSA id s15-20020a5d4ecf000000b0021b9416fa13sm3758184wrv.90.2022.07.15.00.47.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Jul 2022 00:47:05 -0700 (PDT) Date: Fri, 15 Jul 2022 09:47:03 +0200 From: Juri Lelli To: Ankit Jain Cc: "srivatsa@csail.mit.edu" , LKML , linux-rt-users , Ingo Molnar , Peter Zijlstra , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Daniel Bristot de Oliveira , Valentin Schneider , Sharan Turlapati , Him Kalyan Bordoloi , Keerthana Kalyanasundaram , Anish Swaminathan , Srivatsa Bhat Subject: Re: [PATCH] sched/deadline: Fix BUG_ON condition for deboosted tasks Message-ID: References: <20220713075014.411739-1-juri.lelli@redhat.com> <806a86d3-5204-145e-af46-023bf0142aa8@csail.mit.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-rt-users@vger.kernel.org Hi, On 15/07/22 04:49, Ankit Jain wrote: [...] > Hi Juri, > > I tried the patch but it still hit the BUG_ON. > > [ 163.094094] ------------[ cut here ]------------ > [ 163.094095] kernel BUG at kernel/sched/deadline.c:1525! > [ 163.094103] invalid opcode: 0000 [#1] PREEMPT SMP PTI > [ 163.094105] CPU: 0 PID: 5494 Comm: stalld/34 Not tainted 4.19.247-rt108-10.ph3-rt #1-photon > [ 163.094107] Hardware name: VMware, Inc. VMware Virtual Platform/440BX Desktop Reference Platform, BIOS 6.00 07/03/2018 > [ 163.094113] RIP: 0010:enqueue_task_dl+0x35d/0x9d0 > [ 163.094115] Code: 83 c4 10 5b 41 5c 41 5d 41 5e 41 5f 5d c3 8b 56 74 85 d2 0f 88 91 fd ff ff 80 a6 0c 03 00 00 fe 41 83 e5 20 0f 85 > [ 163.094116] RSP: 0018:ffff9b9286537e40 EFLAGS: 00010046 > [ 163.094118] RAX: ffffffff840bded0 RBX: ffff8dda07c48000 RCX: 0000000000002000 > [ 163.094119] RDX: 0000000000000078 RSI: ffff8dda07c48000 RDI: ffff8dddb79a87c0 > [ 163.094120] RBP: ffff9b9286537e78 R08: 0000000000000000 R09: 000000000000007f > [ 163.094121] R10: ffff9b9286537e68 R11: 0000000000000000 R12: ffff9b9286537ef0 > [ 163.094121] R13: 0000000000000000 R14: ffff8dddb79a87c0 R15: ffff8dda07c482b8 > [ 163.094123] FS: 00007f81a27e4700(0000) GS:ffff8ddbb7600000(0000) knlGS:0000000000000000 > [ 163.094124] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > [ 163.094125] CR2: 00007f85e6cfc4c0 CR3: 0000000233744004 CR4: 00000000007606b0 > [ 163.094176] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 > [ 163.094177] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 > [ 163.094177] PKRU: 55555554 > [ 163.094178] Call Trace: > [ 163.094183] ? dequeue_task_dl+0x38/0x1d0 > [ 163.094188] __sched_setscheduler+0x2e2/0x8e0 > [ 163.094191] __x64_sys_sched_setattr+0x74/0xb0 > [ 163.094194] do_syscall_64+0x60/0x1b0 > [ 163.094200] entry_SYSCALL_64_after_hwframe+0x44/0xa9 > [ 163.094201] RIP: 0033:0x7f81b6ffe319 > [ 163.094202] Code: 00 f3 c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c > [ 163.094203] RSP: 002b:00007f81a27e3e28 EFLAGS: 00000206 ORIG_RAX: 000000000000013a > [ 163.094205] RAX: ffffffffffffffda RBX: 000000000000150a RCX: 00007f81b6ffe319 > [ 163.094205] RDX: 0000000000000000 RSI: 00007f81a27e3e50 RDI: 000000000000150a > [ 163.094206] RBP: 000000000000150a R08: 0000000000000000 R09: 0000000000000030 > [ 163.094207] R10: 00007f80f0002090 R11: 0000000000000206 R12: 0000556306de7a20 > [ 163.094208] R13: 0000000000000002 R14: 0000556306ba3570 R15: 00007f81a27e4700 > [ 163.094210] Modules linked in: ipt_MASQUERADE nf_conntrack_netlink nfnetlink xfrm_user xfrm_algo xt_addrtype br_netfilter bridge stp > [ 163.099512] ---[ end trace 0000000000000002 ]--- > > > In enqueue_task_dl(): > > } else if (!dl_prio(p->normal_prio)) { > … > BUG_ON(!(flags & ENQUEUE_REPLENISH)); > return; > } > > I observe flags value as (ENQUEUE_RESTORE | ENQUEUE_NOCLOCK) Thanks for testing! However, it looks like 4.19-rt is at least missing commit 46fcc4b00c3cc ("sched/deadline: Fix stale throttling on de-/boosted tasks") and commit 2279f540ea7d0 ("sched/deadline: Fix priority inheritance with multiple scheduling classes") that might be playing also a role here. Best, Juri