From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02CA3C00140 for ; Fri, 5 Aug 2022 17:03:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237268AbiHERDp (ORCPT ); Fri, 5 Aug 2022 13:03:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57412 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229674AbiHERDn (ORCPT ); Fri, 5 Aug 2022 13:03:43 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 1172F6C10C for ; Fri, 5 Aug 2022 10:03:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1659719021; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=CjLdGtZ7T3o2PFAn8MVkTV+FoCZ69HaAQuDiqFDbFUA=; b=YiZgUVA8fznaYpr/7++nSQ+Uo7YJPJctIqfvkL8ZF+8a7QMUCPySo07To5HDp04YXJqUPU z/864oEjUMH7y29zJUrnSTp5h5GtdBWtApluleciUH0P/7EdfJvBKY69VlEZ6YyyUdf8hS VaNoPwTsGUT14hHIzHdZZZjjfXjiCX8= Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-252-5yRKgcTdNKKpxKbhUGIAuA-1; Fri, 05 Aug 2022 13:03:40 -0400 X-MC-Unique: 5yRKgcTdNKKpxKbhUGIAuA-1 Received: by mail-qt1-f199.google.com with SMTP id h6-20020ac87146000000b0033eb4c65676so2290580qtp.11 for ; Fri, 05 Aug 2022 10:03:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=CjLdGtZ7T3o2PFAn8MVkTV+FoCZ69HaAQuDiqFDbFUA=; b=DkSINuOwGlgWIF/iFQfFNYTsIhRpc+7urAwBssQfumc4UF9WuQbtXUap0P7Pwwxk3e 9G30gXZ8QZbcTZ+NshAsY1yb3mRFaKNzYKwHUBxGGnojQuiNJc/fCoqKKx4BKkWJ+7to 3ankU9NXcdmpgfWEbkoUQMgLeqWMQQ/OOnmo3Anmc71tEmSY8lqdVNUHnOdFtcwvu/Ym 8hvWKM02XZ5jD3+7mAvnLiK+jfoUz/snv9NyMxbrDFU1rY2dlZpU4Onky+J9P3TMcb3y ur9NlE80EEKe8mxzNg800F+cdUR349kgStD/Qxfb4VSwld+REzVu5b4F64QCxQ0vcJ8s irxQ== X-Gm-Message-State: ACgBeo1k0kLA1I/3JDeXnYlg3vWceWTJQWYxR9w/3Cso89LfU+PtilYD MyBId9FFzB3ZUzTy1/7m8OULyy05BymWMTvy9+mv26u9SEdt0e7S+rPMHSEtpaEgUQCof/+Q/gS HijOz/pjzGTl2zOCGp0L30glsSC0= X-Received: by 2002:a05:620a:6c4:b0:6b5:d024:ccca with SMTP id 4-20020a05620a06c400b006b5d024cccamr5754232qky.324.1659719019272; Fri, 05 Aug 2022 10:03:39 -0700 (PDT) X-Google-Smtp-Source: AA6agR4xUnf2lh8qeo31a2toxbpCSTAzIvFhNgcPxyCoG9clffhzWFTPqmtPIhiwWZsP5U6J5Wk0VQ== X-Received: by 2002:a05:620a:6c4:b0:6b5:d024:ccca with SMTP id 4-20020a05620a06c400b006b5d024cccamr5754196qky.324.1659719018722; Fri, 05 Aug 2022 10:03:38 -0700 (PDT) Received: from lleshchi.bos.csb (cpe-24-198-132-134.maine.res.rr.com. [24.198.132.134]) by smtp.gmail.com with ESMTPSA id u11-20020a05620a0c4b00b006b60c965024sm3250634qki.113.2022.08.05.10.03.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Aug 2022 10:03:38 -0700 (PDT) Date: Fri, 5 Aug 2022 13:03:35 -0400 From: Leah Leshchinsky To: John Kacur Cc: linux-rt-users@vger.kernel.org Subject: Re: [PATCH v2] rteval: Add measurement and load location to run report Message-ID: References: <20220804154807.252163-1-lleshchi@redhat.com> <8047d387-1396-c2ff-70e5-aa448a907fb4@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8047d387-1396-c2ff-70e5-aa448a907fb4@redhat.com> Precedence: bulk List-ID: X-Mailing-List: linux-rt-users@vger.kernel.org On Fri, Aug 05, 2022 at 12:32:32PM -0400, John Kacur wrote: > > > On Fri, 5 Aug 2022, Leah Leshchinsky wrote: > > > On Thu, Aug 04, 2022 at 11:48:07AM -0400, Leah Leshchinsky wrote: > > > The run report produced at the end of a run does not contain information > > > on load and measurement thread locations. > > > > > > Adjust MakeReport() functions of LoadModules and MeasurementModules > > > class so that new properties with number of loads and cpu information > > > are added to the XML report and can be read by rteval_text.xsl. > > > > > > Signed-off-by: Leah Leshchinsky > > > > > > diff --git a/rteval/modules/loads/__init__.py b/rteval/modules/loads/__init__.py > > > index 2c2105efa964..5e5a5d85b616 100644 > > > --- a/rteval/modules/loads/__init__.py > > > +++ b/rteval/modules/loads/__init__.py > > > @@ -30,6 +30,7 @@ import libxml2 > > > from rteval.Log import Log > > > from rteval.rtevalConfig import rtevalCfgSection > > > from rteval.modules import RtEvalModules, rtevalModulePrototype > > > +from rteval.systopology import collapse_cpulist, SysTopology > > > > > > class LoadThread(rtevalModulePrototype): > > > def __init__(self, name, config, logger=None): > > > @@ -131,6 +132,12 @@ class LoadModules(RtEvalModules): > > > def MakeReport(self): > > > rep_n = RtEvalModules.MakeReport(self) > > > rep_n.newProp("load_average", str(self.GetLoadAvg())) > > > + rep_n.newProp("loads", str(self.ModulesLoaded())) > > > + cpulist = self._cfg.GetSection(self._module_config).cpulist > > > + if not cpulist: > > > + st = SysTopology() > > > + cpulist = collapse_cpulist(st.online_cpus()) > > > + rep_n.newProp("loadcpus", cpulist) > > > > > > return rep_n > > > > > > diff --git a/rteval/modules/measurement/__init__.py b/rteval/modules/measurement/__init__.py > > > index 318248bd7e35..371fc5d08f44 100644 > > > --- a/rteval/modules/measurement/__init__.py > > > +++ b/rteval/modules/measurement/__init__.py > > > @@ -24,7 +24,7 @@ > > > > > > import libxml2 > > > from rteval.modules import RtEvalModules, ModuleContainer > > > - > > > +from rteval.systopology import collapse_cpulist, SysTopology > > > > > > class MeasurementProfile(RtEvalModules): > > > """Keeps and controls all the measurement modules with the same measurement profile""" > > > @@ -189,6 +189,12 @@ measurement profiles, based on their characteristics""" > > > > > > # Get the reports from all meaurement modules in all measurement profiles > > > rep_n = libxml2.newNode("Measurements") > > > + cpulist = self.__cfg.GetSection("measurement").cpulist > > > + if not cpulist: > > > + st = SysTopology() > > > + cpulist = collapse_cpulist(st.online_cpus()) > > > + rep_n.newProp("measurecpus", cpulist) > > > + > > > for mp in self.__measureprofiles: > > > mprep_n = mp.MakeReport() > > > if mprep_n: > > > diff --git a/rteval/rteval_text.xsl b/rteval/rteval_text.xsl > > > index c40063e3dd19..7ecfac6b6140 100644 > > > --- a/rteval/rteval_text.xsl > > > +++ b/rteval/rteval_text.xsl > > > @@ -13,6 +13,14 @@ > > > > > > > > > > > > + Loads: > > > + loads run on cores > > > + > > > + > > > + Measurement: > > > + measurement threads run on cores > > > + > > > + > > > Run time: > > > days > > > h > > > -- > > > 2.31.1 > > > > > > > Hi John, > > > > I do believe the cpulist variable can be empty. I was able to test this by running rteval without specifying and load and measurement cpus. > > Ok, you are correct, cpulist can be empty if the following are not set > --loads-cpulist=LIST > --measurement-cpulist=LIST > > So you do need some code to initialize the list of it is empty. > But there are still problems > > For example if you shut off cpu 3 > su -c 'echo 0 > /sys/devices/system/cpu/cpu3/online ' > > And then request measurement on cpus 0-5 > su -c './rteval-cmd -d5s --measurement-cpulist=0-5' > > The report should say > Measurement: measurement threads run on cores 0-2,4,5 > Loads: 3 loads run on cores 6-11 (the inverse) > but instead with your patch it says > Loads: 3 loads run on cores 1,2,4,6,7,8,9,10,11 > Measurement: measurement threads run on cores 0-5 > > Now there are problems that exist even before your patch, so for example, > the initial info to the screen not included in the report doesn't consider > offline cpus. (We should fix that too of course, but we can do this > stepwise) > > And it's also possible that I have introduced some new problems with the > changes to systopology that will hopefully make things simpler in the long > run but may be interferring with your code. So, there are many things to > untangle here. > > > > > This patch is attempting to replicate the behavior found in rteval/__init.py lines 187-201, which also finds the cpulist using > > cpulist = self._loadmods._cfg.GetSection("loads").cpulist > > and if the cpulist is empty, defaults to reporting the online cpus. I assume this is because the rteval program uses all available cpus > > to run measurement and load threads if no specific cpus are specified. > > > > Please let me know if I am misunderstanding any of the above. > > > > I will investigate why the xsl code is not working for you. It seems to be working for me at the moment. > > > > > > Thank you for the review, > > Leah > > > > > Thanks Leah > > John > Hi John, > The report should say > Measurement: measurement threads run on cores 0-2,4,5 > Loads: 3 loads run on cores 6-11 (the inverse) > but instead with your patch it says > Loads: 3 loads run on cores 1,2,4,6,7,8,9,10,11 > Measurement: measurement threads run on cores 0-5 Now that I'm looking at the rteval program prior to my changes, I see that this issue existed in the initial pre-report posted to stdout. This seems to be a separate bug in the way that 'self._loadmods._cfg.GetSection("loads").cpulist' and self.__cfg.GetSection("measurement").cpulist are calculated. When I test your example on the rteval main branch, this is the result: su -c 'echo 0 > /sys/devices/system/cpu/cpu3/online ' su -c './rteval-cmd -d5s --measurement-cpulist=0-5' started 3 loads on cores 1,2,4,6,7 started measurement threads on cores 0-5 Should we file this as a separate bug, since the scope of it goes beyond my current patch? Thanks, Leah