* [PATCH] oslat: remove newline from tracemark message
@ 2023-06-01 20:04 Marcelo Tosatti
2023-06-02 21:05 ` John Kacur
0 siblings, 1 reply; 2+ messages in thread
From: Marcelo Tosatti @ 2023-06-01 20:04 UTC (permalink / raw)
To: John Kacur; +Cc: linux-rt-users
Remove the newline from the trace mark message: it breaks
tools that expect the trace files to contain the standard
trace format on each new trace line.
Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
diff --git a/src/oslat/oslat.c b/src/oslat/oslat.c
index b680f1e..99f86b8 100644
--- a/src/oslat/oslat.c
+++ b/src/oslat/oslat.c
@@ -337,8 +337,7 @@ static void insert_bucket(struct thread *t, stamp_t value)
lat = (value * g.unit_per_us + t->counter_mhz - 1) / t->counter_mhz;
us = (double)lat / g.unit_per_us;
if (!g.preheat && g.trace_threshold && us >= g.trace_threshold) {
- char *line = "%s: Trace threshold (%d us) triggered on cpu %d with %.*f us!\n"
- "Stopping the test.\n";
+ char *line = "%s: Trace threshold (%d us) triggered on cpu %d with %.*f us!\n";
tracemark(line, g.app_name, g.trace_threshold, t->core_i,
g.precision, us);
err_quit(line, g.app_name, g.trace_threshold, t->core_i,
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] oslat: remove newline from tracemark message
2023-06-01 20:04 [PATCH] oslat: remove newline from tracemark message Marcelo Tosatti
@ 2023-06-02 21:05 ` John Kacur
0 siblings, 0 replies; 2+ messages in thread
From: John Kacur @ 2023-06-02 21:05 UTC (permalink / raw)
To: Marcelo Tosatti; +Cc: linux-rt-users
On Thu, 1 Jun 2023, Marcelo Tosatti wrote:
>
> Remove the newline from the trace mark message: it breaks
> tools that expect the trace files to contain the standard
> trace format on each new trace line.
>
> Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
>
> diff --git a/src/oslat/oslat.c b/src/oslat/oslat.c
> index b680f1e..99f86b8 100644
> --- a/src/oslat/oslat.c
> +++ b/src/oslat/oslat.c
> @@ -337,8 +337,7 @@ static void insert_bucket(struct thread *t, stamp_t value)
> lat = (value * g.unit_per_us + t->counter_mhz - 1) / t->counter_mhz;
> us = (double)lat / g.unit_per_us;
> if (!g.preheat && g.trace_threshold && us >= g.trace_threshold) {
> - char *line = "%s: Trace threshold (%d us) triggered on cpu %d with %.*f us!\n"
> - "Stopping the test.\n";
> + char *line = "%s: Trace threshold (%d us) triggered on cpu %d with %.*f us!\n";
> tracemark(line, g.app_name, g.trace_threshold, t->core_i,
> g.precision, us);
> err_quit(line, g.app_name, g.trace_threshold, t->core_i,
>
>
Signed-off-by: John Kacur <jkacur@redhat.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-06-02 21:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-06-01 20:04 [PATCH] oslat: remove newline from tracemark message Marcelo Tosatti
2023-06-02 21:05 ` John Kacur
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox