public inbox for linux-rt-users@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] rt-tests: oslat should use MHz, not Mhz
@ 2024-02-01 16:05 Marcelo Tosatti
  2024-02-02 16:33 ` John Kacur
  0 siblings, 1 reply; 2+ messages in thread
From: Marcelo Tosatti @ 2024-02-01 16:05 UTC (permalink / raw)
  To: linux-rt-users; +Cc: Newman, Chuck, John Kacur


Usage of Mhz, in oslat, is incorrect:

From https://www.nist.gov/pml/owm/writing-si-metric-system-units#:~:text=NOT%20250%20mms.-,Capitalization,the%20beginning%20of%20the%20sentence:

"When the unit is derived from the name of a person, the symbol or the first letter of the symbol is an uppercase letter (W for the unit "watt" or Pa for the unit "pascal")."

Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
Reported-by: Chuck Newman <chuck.newman@hpe.com>

diff --git a/src/oslat/oslat.c b/src/oslat/oslat.c
index 4bdca64..e398f20 100644
--- a/src/oslat/oslat.c
+++ b/src/oslat/oslat.c
@@ -501,7 +501,7 @@ static void write_summary(struct thread *t)
 	calculate(t);
 
 	putfield("Core", t[i].core_i, "d", "");
-	putfield("Counter Freq", t[i].counter_mhz, "u", " (Mhz)");
+	putfield("Counter Freq", t[i].counter_mhz, "u", " (MHz)");
 
 	for (j = 0; j < g.bucket_size; j++) {
 		if (j < g.bucket_size-1 && g.output_omit_zero_buckets) {


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] rt-tests: oslat should use MHz, not Mhz
  2024-02-01 16:05 [PATCH] rt-tests: oslat should use MHz, not Mhz Marcelo Tosatti
@ 2024-02-02 16:33 ` John Kacur
  0 siblings, 0 replies; 2+ messages in thread
From: John Kacur @ 2024-02-02 16:33 UTC (permalink / raw)
  To: Marcelo Tosatti; +Cc: linux-rt-users, Newman, Chuck



On Thu, 1 Feb 2024, Marcelo Tosatti wrote:

> 
> Usage of Mhz, in oslat, is incorrect:
> 
> From https://www.nist.gov/pml/owm/writing-si-metric-system-units#:~:text=NOT%20250%20mms.-,Capitalization,the%20beginning%20of%20the%20sentence:
> 
> "When the unit is derived from the name of a person, the symbol or the first letter of the symbol is an uppercase letter (W for the unit "watt" or Pa for the unit "pascal")."
> 
> Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>
> Reported-by: Chuck Newman <chuck.newman@hpe.com>
> 
> diff --git a/src/oslat/oslat.c b/src/oslat/oslat.c
> index 4bdca64..e398f20 100644
> --- a/src/oslat/oslat.c
> +++ b/src/oslat/oslat.c
> @@ -501,7 +501,7 @@ static void write_summary(struct thread *t)
>  	calculate(t);
>  
>  	putfield("Core", t[i].core_i, "d", "");
> -	putfield("Counter Freq", t[i].counter_mhz, "u", " (Mhz)");
> +	putfield("Counter Freq", t[i].counter_mhz, "u", " (MHz)");
>  
>  	for (j = 0; j < g.bucket_size; j++) {
>  		if (j < g.bucket_size-1 && g.output_omit_zero_buckets) {
> 
> 
> 
Signed-off-by: John Kacur <jkacur@redhat.com>


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-02-02 16:33 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-01 16:05 [PATCH] rt-tests: oslat should use MHz, not Mhz Marcelo Tosatti
2024-02-02 16:33 ` John Kacur

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox