linux-rt-users.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Viresh Kumar <viresh.kumar@linaro.org>
To: tj@kernel.org
Cc: davem@davemloft.net, airlied@redhat.com, axboe@kernel.dk,
	tglx@linutronix.de, peterz@infradead.org, mingo@redhat.com,
	rostedt@goodmis.org, linux-rt-users@vger.kernel.org,
	linux-kernel@vger.kernel.org, robin.randhawa@arm.com,
	Steve.Bannister@arm.com, Liviu.Dudau@arm.com,
	charles.garcia-tobin@arm.com, arvind.chauhan@arm.com,
	linaro-kernel@lists.linaro.org, patches@linaro.org,
	Viresh Kumar <viresh.kumar@linaro.org>,
	netdev@vger.kernel.org
Subject: [PATCH V5 3/5] PHYLIB: queue work on system_power_efficient_wq
Date: Wed, 24 Apr 2013 17:12:55 +0530	[thread overview]
Message-ID: <a24dfa8042c4b8956163e855e53def7f7a53c137.1366803121.git.viresh.kumar@linaro.org> (raw)
In-Reply-To: <cover.1366803121.git.viresh.kumar@linaro.org>
In-Reply-To: <cover.1366803121.git.viresh.kumar@linaro.org>

Phylib uses workqueues for multiple purposes. There is no real dependency of
scheduling these on the cpu which scheduled them.

On a idle system, it is observed that and idle cpu wakes up many times just to
service this work. It would be better if we can schedule it on a cpu which the
scheduler believes to be the most appropriate one.

This patch replaces system_wq with system_power_efficient_wq for PHYLIB.

Cc: David S. Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Acked-by: David S. Miller <davem@davemloft.net>
---
 drivers/net/phy/phy.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c
index c14f147..984c0b5 100644
--- a/drivers/net/phy/phy.c
+++ b/drivers/net/phy/phy.c
@@ -439,7 +439,7 @@ void phy_start_machine(struct phy_device *phydev,
 {
 	phydev->adjust_state = handler;
 
-	schedule_delayed_work(&phydev->state_queue, HZ);
+	queue_delayed_work(system_power_efficient_wq, &phydev->state_queue, HZ);
 }
 
 /**
@@ -500,7 +500,7 @@ static irqreturn_t phy_interrupt(int irq, void *phy_dat)
 	disable_irq_nosync(irq);
 	atomic_inc(&phydev->irq_disable);
 
-	schedule_work(&phydev->phy_queue);
+	queue_work(system_power_efficient_wq, &phydev->phy_queue);
 
 	return IRQ_HANDLED;
 }
@@ -655,7 +655,7 @@ static void phy_change(struct work_struct *work)
 
 	/* reschedule state queue work to run as soon as possible */
 	cancel_delayed_work_sync(&phydev->state_queue);
-	schedule_delayed_work(&phydev->state_queue, 0);
+	queue_delayed_work(system_power_efficient_wq, &phydev->state_queue, 0);
 
 	return;
 
@@ -918,7 +918,8 @@ void phy_state_machine(struct work_struct *work)
 	if (err < 0)
 		phy_error(phydev);
 
-	schedule_delayed_work(&phydev->state_queue, PHY_STATE_TIME * HZ);
+	queue_delayed_work(system_power_efficient_wq, &phydev->state_queue,
+			PHY_STATE_TIME * HZ);
 }
 
 static inline void mmd_phy_indirect(struct mii_bus *bus, int prtad, int devad,
-- 
1.7.12.rc2.18.g61b472e

  parent reply	other threads:[~2013-04-24 11:42 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-24 11:42 [PATCH V5 0/5] Queue work on power efficient wq Viresh Kumar
2013-04-24 11:42 ` [PATCH V5 1/5] workqueues: Introduce new flag WQ_POWER_EFFICIENT for power oriented workqueues Viresh Kumar
2013-04-24 12:20   ` Amit Kucheria
2013-04-24 12:27     ` Viresh Kumar
2013-04-24 16:12       ` Tejun Heo
     [not found]         ` <CAP245DUGuaSQbP4026N8kgn6-NqXFJWR3zKoYud=HQ_b+v5+Xw@mail.gmail.com>
2013-04-25  3:43           ` Viresh Kumar
2013-04-25 11:13             ` Amit Kucheria
2013-04-25 11:15               ` Viresh Kumar
2013-04-26 19:11             ` Tejun Heo
2013-04-29  6:36               ` Viresh Kumar
2013-04-29 16:19                 ` Tejun Heo
2013-04-29 16:42                   ` Viresh Kumar
2013-05-13  8:29               ` Viresh Kumar
2013-05-14 17:55                 ` Tejun Heo
2013-04-24 11:42 ` [PATCH V5 2/5] workqueue: Add system wide power_efficient workqueues Viresh Kumar
2013-05-14 17:56   ` Tejun Heo
2013-04-24 11:42 ` Viresh Kumar [this message]
2013-04-24 11:42 ` [PATCH V5 4/5] block: queue work on power efficient wq Viresh Kumar
2013-05-14 17:57   ` Tejun Heo
2013-04-24 11:42 ` [PATCH V5 5/5] fbcon: " Viresh Kumar
2013-05-14 17:57   ` Tejun Heo
2013-05-14 17:54 ` [PATCH V5 0/5] Queue " Tejun Heo
2013-05-15  5:48   ` Viresh Kumar
2013-07-08 15:37 ` Uwe Kleine-König
2013-07-08 15:47   ` Viresh Kumar
2013-07-08 15:57     ` Uwe Kleine-König
2013-07-08 16:48       ` Viresh Kumar
2013-07-08 18:55         ` Uwe Kleine-König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a24dfa8042c4b8956163e855e53def7f7a53c137.1366803121.git.viresh.kumar@linaro.org \
    --to=viresh.kumar@linaro.org \
    --cc=Liviu.Dudau@arm.com \
    --cc=Steve.Bannister@arm.com \
    --cc=airlied@redhat.com \
    --cc=arvind.chauhan@arm.com \
    --cc=axboe@kernel.dk \
    --cc=charles.garcia-tobin@arm.com \
    --cc=davem@davemloft.net \
    --cc=linaro-kernel@lists.linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rt-users@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=patches@linaro.org \
    --cc=peterz@infradead.org \
    --cc=robin.randhawa@arm.com \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).