Re: [stalld v2 3/6] Makefile: Explicitly run the 'test' target in the tests directory

[Clark Williams <williams@redhat.com>]

On Mon, Nov 10, 2025 at 10:22:38AM -0300, Wander Lairson Costa wrote:
> The 'tests' target in the main Makefile was invoking 'make' in the
> 'tests' subdirectory without specifying a target. This relied on the
> default target in the tests/Makefile, which is not explicit.
> 
> This commit adds the 'test' target to the make command, making the
> build process clearer and more robust.
> 
> Signed-off-by: Wander Lairson Costa <wander@redhat.com>
> Cc: Derek Barbosa <debarbos@redhat.com>
> Cc: John Kacur <jkacur@redhat.com>
> Cc: Juri Lelli <juri.lelli@redhat.com>
> Cc: Chunsheng Luo <luochunsheng@ustc.edu>
> ---
>  Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Makefile b/Makefile
> index 23e786d..619413f 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -183,7 +183,7 @@ static: $(OBJ)
>  	$(CC) -o stalld-static $(LDFLAGS) --static $(OBJ) $(LIBS)
>  
>  tests:
> -	make -C tests VERSION=$(VERSION) CFLAGS="$(CFLAGS)" LDFLAGS="$(LDFLAGS)"
> +	make -C tests VERSION=$(VERSION) CFLAGS="$(CFLAGS)" LDFLAGS="$(LDFLAGS)" test
>  

How do you feel about adding a 'sudo' to the make invocation, either
here or in the tests/Makefile?

If you don't then the tests run and all pass. If you run it as sudo you
find that there are still a couple of failures. 

Clark
-- 
The United States Coast Guard
Ruining Natural Selection since 1790