Re: [stalld v2 1/6] Makefile: Conditionally add -mno-omit-leaf-frame-pointer

[Clark Williams <williams@redhat.com>]

On Mon, Nov 10, 2025 at 10:22:36AM -0300, Wander Lairson Costa wrote:
> The -mno-omit-leaf-frame-pointer option is not available on all
> architectures (e.g., s390x) or with older compiler versions. To avoid
> compilation errors on such systems, this change adds a check to ensure
> the option is only used when the compiler supports it.
> 
> This approach is similar to the existing check for -fcf-protection.
> 
> Signed-off-by: Wander Lairson Costa <wander@redhat.com>
> Cc: Derek Barbosa <debarbos@redhat.com>
> Cc: John Kacur <jkacur@redhat.com>
> Cc: Juri Lelli <juri.lelli@redhat.com>
> Cc: Chunsheng Luo <luochunsheng@ustc.edu>
> ---
>  Makefile | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/Makefile b/Makefile
> index c19e0bd..d605e60 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -60,7 +60,13 @@ FOPTS	:=	-flto=auto -ffat-lto-objects -fexceptions -fstack-protector-strong \
>  		-fasynchronous-unwind-tables -fstack-clash-protection -fno-omit-frame-pointer \
>  		$(strip $(FCF_PROTECTION)) -fpie
>  
> -MOPTS   :=  	$(strip $(MTUNE)) $(strip $(M64)) -mno-omit-leaf-frame-pointer
> +# Test if compiler supports -mno-omit-leaf-frame-pointer
> +OMIT_LEAF_FP := $(shell echo 'int main(void){return 0;}' | \
> +		$(CC) -x c -mno-omit-leaf-frame-pointer - \
> +		-o /dev/null 2>/dev/null && \
> +		echo '-mno-omit-leaf-frame-pointer')
> +
> +MOPTS   :=  	$(strip $(MTUNE)) $(strip $(M64)) $(strip $(OMIT_LEAF_FP))
>  
>  WOPTS	:= 	-Wall -Werror=format-security
>  
> -- 
> 2.51.1
> 
Signed-off-by: Clark Williams <williams@redhat.com>
-- 
The United States Coast Guard
Ruining Natural Selection since 1790