From: Thomas Gleixner <tglx@linutronix.de>
To: Julia Cartwright <julia@ni.com>
Cc: Grygorii Strashko <grygorii.strashko@ti.com>,
Steven Rostedt <rostedt@goodmis.org>,
Lionel Debieve <lionel.debieve@st.com>,
linux-rt-users@vger.kernel.org, linux-kernel@vger.kernel.org,
bigeasy@linutronix.de
Subject: Re: [PATCH RT 1/1] remoteproc: Prevent schedule while atomic
Date: Fri, 24 Mar 2017 09:38:20 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.20.1703240935250.3688@nanos> (raw)
In-Reply-To: <20170322184733.GL10423@jcartwri.amer.corp.natinst.com>
On Wed, 22 Mar 2017, Julia Cartwright wrote:
> On Wed, Mar 22, 2017 at 01:30:12PM -0500, Grygorii Strashko wrote:
> > It will not be threaded because there are IRQF_ONESHOT used.
> >
> > ret = devm_request_threaded_irq(&pdev->dev, irq,
> > sti_mbox_irq_handler,
> > sti_mbox_thread_handler,
> > IRQF_ONESHOT, mdev->name, mdev);
>
> Indeed. I had skipped over this important detail when I was skimming
> through the code.
>
> Thanks for clarifying!
>
> Is IRQF_ONESHOT really necessary for this device? The primary handler
> invokes sti_mbox_disable_channel() on the interrupting channel, which I
> would hope would acquiesce the pending interrupt at the device-level?
Well, this is a typical case of well done split into primary and threaded
handler. There is no advantage on RT to force this into double threaded
handling. Making the lock raw is definitely the proper solution here.
Thanks,
tglx
prev parent reply other threads:[~2017-03-24 8:38 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-22 15:18 [PATCH RT 1/1] remoteproc: Prevent schedule while atomic Lionel Debieve
2017-03-22 16:05 ` Steven Rostedt
2017-03-22 17:15 ` Lionel DEBIEVE
2017-03-29 16:06 ` Sebastian Andrzej Siewior
2017-03-30 7:54 ` Lee Jones
2017-04-04 8:33 ` Lionel DEBIEVE
2017-03-22 17:37 ` Julia Cartwright
2017-03-22 18:01 ` Steven Rostedt
2017-03-22 18:30 ` Grygorii Strashko
2017-03-22 18:47 ` Julia Cartwright
2017-03-23 8:28 ` Lionel DEBIEVE
2017-03-23 10:26 ` Lee Jones
2017-03-23 20:51 ` Julia Cartwright
2017-03-28 9:31 ` Lee Jones
2017-03-24 8:38 ` Thomas Gleixner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1703240935250.3688@nanos \
--to=tglx@linutronix.de \
--cc=bigeasy@linutronix.de \
--cc=grygorii.strashko@ti.com \
--cc=julia@ni.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=lionel.debieve@st.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox