From: Thomas Gleixner <tglx@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: linux-rt-users <linux-rt-users@vger.kernel.org>,
Sebastian Sewior <bigeasy@linutronix.de>,
Steven Rostedt <rostedt@goodmis.org>,
Peter Zijlstra <peterz@infradead.org>,
Mathias Koehrer <mathias.koehrer@etas.com>,
David Hauck <davidh@netacquire.com>
Subject: Re: [PATCH RT] sched: Prevent task state corruption by spurious lock wakeup
Date: Tue, 6 Jun 2017 14:16:38 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.20.1706061412290.1885@nanos> (raw)
In-Reply-To: <alpine.DEB.2.20.1706030940220.2228@nanos>
On Sat, 3 Jun 2017, Thomas Gleixner wrote:
> If the to be woken task has state TASK_TRACED then the wakeup state check
> should not match. But for some stupid reason wake_up_lock_sleeper() should
> not use TASK_ALL. The lock sleepers are in state UNINTERRUPTIBLE, so the
> wake state should be UNINTERRUPTIBLE as well.
>
> The extra check in try_to_wake_up() should stay though as it prevents
> spurious wake ups in general.
Further experimentation shows that it's not worth it. I'll send a V2 of
that patch with the proper fix.
Thanks,
tglx
next prev parent reply other threads:[~2017-06-06 12:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-02 16:40 [PATCH RT] sched: Prevent task state corruption by spurious lock wakeup Thomas Gleixner
2017-06-02 17:25 ` David Hauck
2017-06-03 7:47 ` Thomas Gleixner
2017-06-06 12:16 ` Thomas Gleixner [this message]
2017-06-06 12:20 ` [PATCH RT V2] " Thomas Gleixner
2017-06-06 16:28 ` Peter Zijlstra
2017-06-06 18:35 ` Thomas Gleixner
2017-06-07 20:18 ` Sebastian Sewior
2017-06-07 20:18 ` Sebastian Sewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1706061412290.1885@nanos \
--to=tglx@linutronix.de \
--cc=bigeasy@linutronix.de \
--cc=davidh@netacquire.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=mathias.koehrer@etas.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox