From: Anna-Maria Gleixner <anna-maria@linutronix.de>
To: Haris Okanovic <haris.okanovic@ni.com>
Cc: linux-rt-users@vger.kernel.org, linux-kernel@vger.kernel.org,
harisokn@gmail.com, bigeasy@linutronix.de, tglx@linutronix.de,
julia.cartwright@ni.com, gratian.crisan@ni.com,
daniel@bristot.me, efault@gmx.de
Subject: Re: [PATCH v5 1/2] timers: Don't wake ktimersoftd on every tick
Date: Fri, 13 Jul 2018 14:01:45 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.21.1807131354560.2242@somnus> (raw)
In-Reply-To: <20180628164036.27378-1-haris.okanovic@ni.com>
Hi Haris,
On Thu, 28 Jun 2018, Haris Okanovic wrote:
> Collect expired timers in interrupt context to avoid overhead of waking
> ktimersoftd on every scheduler tick.
>
> This is implemented by storing lists of expired timers in the timer_base
> struct, which is updated by the interrupt routing on each tick in
> run_local_timers(). TIMER softirq (ktimersoftd) is then raised only when
> one or more expired timers are collected.
>
> Performance impact on a 2core Intel Atom E3825 system:
> * reduction in small latency spikes measured by cyclictest
> * ~30% fewer context-switches measured by perf
> * run_local_timers() execution time increases by 0.2 measured by TSC
>
I'm also working on timer improvements at the moment. When I fixed all
my bugs in my implementation (there is a last horrible one), I'm very
interested in integrating your patches into my testing to be able to
give you a tested-by.
Thanks,
Anna-Maria
next prev parent reply other threads:[~2018-07-13 12:01 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-13 21:44 [RFC v2] timers: Don't wake ktimersoftd on every tick Haris Okanovic
2016-12-23 17:28 ` Sebastian Andrzej Siewior
2016-12-28 18:06 ` Haris Okanovic
2017-02-03 16:51 ` Sebastian Andrzej Siewior
2017-02-03 18:21 ` [PATCH] " Haris Okanovic
2017-02-10 17:02 ` Sebastian Andrzej Siewior
2017-05-26 17:16 ` [PATCH] Revert "timers: Don't wake ktimersoftd on every tick" Anna-Maria Gleixner
2017-05-26 19:27 ` Haris Okanovic
2017-05-26 19:49 ` Thomas Gleixner
2017-05-26 20:25 ` Haris Okanovic
2017-05-26 20:50 ` Thomas Gleixner
2017-06-02 14:37 ` Haris Okanovic
2017-06-04 14:17 ` Thomas Gleixner
2017-07-17 21:58 ` Haris Okanovic
2017-07-17 22:04 ` [PATCH v2] timers: Don't wake ktimersoftd on every tick Haris Okanovic
2017-07-18 21:33 ` Thomas Gleixner
2017-08-03 21:04 ` Haris Okanovic
2017-08-03 21:06 ` [PATCH v3 1/2] " Haris Okanovic
2017-08-03 21:06 ` [PATCH v3 2/2] timers: Don't search for expired timers while TIMER_SOFTIRQ is scheduled Haris Okanovic
2018-01-05 19:37 ` Haris Okanovic
2018-03-01 15:49 ` Haris Okanovic
2018-03-01 15:54 ` Thomas Gleixner
2018-03-01 16:35 ` Haris Okanovic
2018-03-01 16:47 ` Sebastian Andrzej Siewior
2018-03-01 18:37 ` Haris Okanovic
2018-03-01 19:06 ` Sebastian Andrzej Siewior
2018-03-02 14:52 ` Sebastian Andrzej Siewior
2018-03-02 16:29 ` Haris Okanovic
2018-03-02 16:39 ` Sebastian Andrzej Siewior
2018-03-02 17:19 ` Haris Okanovic
2018-03-06 23:39 ` [PATCH v4 1/2] timers: Don't wake ktimersoftd on every tick Haris Okanovic
2018-03-06 23:39 ` [PATCH v4 2/2] timers: Don't search for expired timers while TIMER_SOFTIRQ is scheduled Haris Okanovic
[not found] ` <1523332961.4827.1.camel@gmx.de>
2018-04-12 15:00 ` [PATCH v4 1/2] timers: Don't wake ktimersoftd on every tick Haris Okanovic
2018-06-19 12:43 ` Daniel Bristot de Oliveira
2018-06-20 14:24 ` Haris Okanovic
2018-06-28 16:36 ` Haris Okanovic
2018-06-28 16:40 ` [PATCH v5 " Haris Okanovic
2018-06-28 16:40 ` [PATCH v5 2/2] timers: Don't search for expired timers while TIMER_SOFTIRQ is scheduled Haris Okanovic
2018-07-13 12:01 ` Anna-Maria Gleixner [this message]
2018-07-13 14:37 ` [PATCH v5 1/2] timers: Don't wake ktimersoftd on every tick Haris Okanovic
2017-05-27 7:47 ` [PATCH] Revert "timers: Don't wake ktimersoftd on every tick" Sebastian Andrzej Siewior
2017-02-03 18:27 ` [RFC v2] timers: Don't wake ktimersoftd on every tick Haris Okanovic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1807131354560.2242@somnus \
--to=anna-maria@linutronix.de \
--cc=bigeasy@linutronix.de \
--cc=daniel@bristot.me \
--cc=efault@gmx.de \
--cc=gratian.crisan@ni.com \
--cc=haris.okanovic@ni.com \
--cc=harisokn@gmail.com \
--cc=julia.cartwright@ni.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox