Re: [PATCH 5/6] [NET] ixp2000/enp2611: don't set non-existent member get_stats

Uwe Kleine-König
2009-08-10T09:40:27Z

Hello,

On Sun, Aug 09, 2009 at 09:49:06PM -0700, David Miller wrote:
> From: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> Date: Fri, 7 Aug 2009 22:42:40 +0200
>
> > This fixes a build failure for 2.6.31-rc5 (ARCH=arm, ixp2000_defconfig):
> >
> > CC drivers/net/ixp2000/enp2611.o
> > drivers/net/ixp2000/enp2611.c: In function 'enp2611_init_module':
> > drivers/net/ixp2000/enp2611.c:213: error: 'struct net_device' has no member named 'get_stats'
> >
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>
> This is far from the way to fix this, unfortunately.
>
> We need to find a way to propagate this assignment into
> the netdev_ops method vector instead.
Yes, I tried that, but stopped when I saw it's declared const. I don't
know if this is required. If yes then the only way to fix it is to add
a platform callback that is called if non-NULL.

I don't want to invest time here without a word by the maintainers
though.

Best regards
Uwe

--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |