public inbox for linux-rt-users@vger.kernel.org
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Remy Bohmer <linux@bohmer.net>
Cc: linux-rt-users <linux-rt-users@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: 2.6.31-rt11 freeze on userland start on ARM
Date: Wed, 30 Sep 2009 14:57:25 +0200 (CEST)	[thread overview]
Message-ID: <alpine.LFD.2.00.0909301448030.2518@nanos> (raw)
In-Reply-To: <3efb10970909211136g4e74c8b3vc339d548cdd0959f@mail.gmail.com>

On Mon, 21 Sep 2009, Remy Bohmer wrote:
> So, as workaround/test I made this change:
> 
> Index: linux-2.6.31/drivers/serial/atmel_serial.c
> ===================================================================
> --- linux-2.6.31.orig/drivers/serial/atmel_serial.c	2009-09-21
> 19:44:48.000000000 +0200
> +++ linux-2.6.31/drivers/serial/atmel_serial.c	2009-09-21
> 19:45:15.000000000 +0200
> @@ -808,7 +808,8 @@ static int atmel_startup(struct uart_por
>  	/*
>  	 * Allocate the IRQ
>  	 */
> -	retval = request_irq(port->irq, atmel_interrupt, IRQF_SHARED,
> +	retval = request_irq(port->irq, atmel_interrupt,
> +			IRQF_SHARED | IRQF_NODELAY,
>  			tty ? tty->name : "atmel_serial", port);
>  	if (retval) {
>  		printk("atmel_serial: atmel_startup - Can't get irq\n");

The serial irq cannot run in hard irq context.

There are two solutions to this problem:

1) Use the other timer which is available on AT91.

2) Make the serial driver explicitely threaded and check in the
hardirq handler whether the irq originated from the serial driver. If
yes, disable it in the serial device and return IRQ_WAKE_THREAD
otherwise return IRQ_NONE.

Thanks,

	tglx

  parent reply	other threads:[~2009-09-30 12:58 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-21 18:36 2.6.31-rt11 freeze on userland start on ARM Remy Bohmer
2009-09-23 23:06 ` Azraiyl
2009-09-24  8:26   ` Remy Bohmer
2009-09-24  9:27 ` yi li
2009-09-30 12:57 ` Thomas Gleixner [this message]
2009-09-30 16:11   ` Remy Bohmer
2009-10-04 11:59     ` Thomas Gleixner
2009-10-04 20:59       ` Remy Bohmer
2009-10-05 10:33         ` Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.00.0909301448030.2518@nanos \
    --to=tglx@linutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rt-users@vger.kernel.org \
    --cc=linux@bohmer.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox