From: Thomas Gleixner <tglx@linutronix.de>
To: Leon Woestenberg <leon.woestenberg@gmail.com>
Cc: rt-users <linux-rt-users@vger.kernel.org>
Subject: Re: -rt kernel hitting yield()s in I2C non-default code paths (2.6.24)
Date: Mon, 2 Nov 2009 15:58:47 +0100 (CET) [thread overview]
Message-ID: <alpine.LFD.2.00.0911021554310.12138@localhost.localdomain> (raw)
In-Reply-To: <c384c5ea0910310239l549a13c5h7289ffc53ff0a648@mail.gmail.com>
On Sat, 31 Oct 2009, Leon Woestenberg wrote:
> Hello,
>
>
> yesterday while debugging embedded systems I noticed the non-happy
> paths in the I2C code hitting yield() code, this resulted in
> a BUG: RT-Task yielding. This was with 2.6.24 (yes I know).
>
> A real-time task (prio 99, low real-time priority) on the generic
> workqueue was executing I2C functions, such as try_address() and
> hitting the yield().
>
> http://lxr.linux.no/#linux+v2.6.31/drivers/i2c/algos/i2c-algo-bit.c#L319
>
> Further grepping shows yield()s sprinkled throughout device driver
> code, especially in the non-default execution paths.
>
> What's the -rt devs opinion on this one?
yield() in kernel code is either a bug or useless nonsense.
> For most of the yield()s I really could not think why they are there...
Exactly. Most likely some blindly copied old code, which needs to be
fixed. Going through it later today.
Thanks for pointing it out.
tglx
prev parent reply other threads:[~2009-11-02 14:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-31 9:39 -rt kernel hitting yield()s in I2C non-default code paths (2.6.24) Leon Woestenberg
2009-11-02 14:58 ` Thomas Gleixner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.00.0911021554310.12138@localhost.localdomain \
--to=tglx@linutronix.de \
--cc=leon.woestenberg@gmail.com \
--cc=linux-rt-users@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox