From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Kacur Subject: Re: [PATCH -rt] Updates-from-Jon-Masters-for-hwlat_detector.c.patch Date: Tue, 3 Nov 2009 14:50:22 +0100 (CET) Message-ID: References: <520f0cf10911021146i136af7bfg370a217185b5154c@mail.gmail.com> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: linux-kernel@vger.kernel.org, Jon Masters , linux-rt-users@vger.kernel.org, Clark Williams To: Thomas Gleixner Return-path: Received: from mx1.redhat.com ([209.132.183.28]:63504 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751332AbZKCNu1 (ORCPT ); Tue, 3 Nov 2009 08:50:27 -0500 In-Reply-To: Sender: linux-rt-users-owner@vger.kernel.org List-ID: On Tue, 3 Nov 2009, Thomas Gleixner wrote: > On Mon, 2 Nov 2009, John Kacur wrote: > > Updated patch just adds the error checking from Jon Masters then, > > patched against -rt. > > Can you please inline patches ? > > @@ -607,7 +607,11 @@ static ssize_t debug_enable_fwrite(stru > if (!enabled) > goto unlock; > enabled = 0; > - stop_kthread(); > + err = stop_kthread(); > + if (0 != err) { > > Eeew ! Yeah, I saw that too and thought it a bit ugly. However, my goal was only to make sure that the latest version of Jon's hwlat patch got into -rt, so I didn't think it was my place to "fix" his style. Note - even the much hated checkpatch program doesn't balk at that. However that is hardly an authority. If you read the introduction to "Expert C Programming - Deep C Secrets", they mention that some programmers write if (3==i) instead of if (i==3) because if you mistakenly only type one '=', then the compiler can complain about it, instead of silently assigning 3 to i. I can only guess that is the sort of idea / habit that Jon got that style from. John