From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Kacur Subject: Re: [PATCH 2/6: v4] lockdep: Make MAX_STACK_TRACE_ENTRIES configurable. Date: Wed, 16 Jun 2010 23:33:42 +0200 (CEST) Message-ID: References: <1276554087-3632-1-git-send-email-jkacur@redhat.com> <1276554087-3632-3-git-send-email-jkacur@redhat.com> <1276714154.1745.623.camel@laptop> <1276723008.2077.9574.camel@twins> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: Thomas Gleixner , lkml , rt-users , Clark Williams , Arnaldo Carvalho de Melo , Ingo Molnar , Sven-Thorsten Dietrich , ghaskins@novell.com To: Peter Zijlstra Return-path: In-Reply-To: <1276723008.2077.9574.camel@twins> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-rt-users.vger.kernel.org On Wed, 16 Jun 2010, Peter Zijlstra wrote: > On Wed, 2010-06-16 at 22:37 +0200, John Kacur wrote: > > > > On Wed, 16 Jun 2010, Peter Zijlstra wrote: > > > > > On Tue, 2010-06-15 at 00:21 +0200, John Kacur wrote: > > > > Certain debug configurations that have LOCKDEP turned on, run into the limit > > > > where the MAX_STACK_TRACE_ENTRIES are too small. Rather than simply turning > > > > off the locking correctness validator, let the user configure this value > > > > to something reasonable for their system. > > > > > > > > This patch was generated against 2.6.33.5-rt23 but is also intended to be > > > > picked-up for mainline. > > > > > > NACK > > > > > > patches like 4726f2a617ebd868a4fdeb5679613b897e5f1676 are the way to go. > > > > I've been testing 4726f2a617ebd868a4fdeb5679613b897e5f1676 in rt > > (Thomas has it in tip/rt/2.6.33 now) and so far it is doing the trick for > > me, at least on my laptop. I still need to test it on larger machines. > > However, this problem seems to continuably come up, and I'm not the only > > one who has expessed the wish / need to have this tunable. > > And simply increasing the number without thought is the worst approach > ever and I'm simply not going to merge it. > > Also, google doesn't seem to index msg-ids, so I've no idea what you're > referring to. > -- The first mail in which Gregory also expressed desire to make this tunable is here http://lkml.org/lkml/2010/4/21/123 The second in which Sven said in certain configurations they might even tune it down (decrease) is here. http://lkml.org/lkml/2010/4/21/183